Page MenuHomeFreeBSD
Differential D30526

pmccontrol: improve -L with pmu-events
ClosedPublic
Actions

Authored by mhorne on May 28 2021, 6:08 PM.
Tags
None
Referenced Files
F159295879: D30526.id.diff
Fri, Jun 12, 1:17 PM
F159231315: D30526.id90210.diff
Thu, Jun 11, 3:15 PM
Unknown Object (File)
Thu, Jun 11, 4:28 AM
Unknown Object (File)
Thu, Jun 4, 6:09 PM
Unknown Object (File)
Fri, May 15, 1:20 PM
Unknown Object (File)
Fri, May 15, 12:31 AM
Unknown Object (File)
Thu, May 14, 11:22 PM
Unknown Object (File)
May 11 2026, 7:21 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
ray
gnn
Group Reviewers
pmc
Commits
rG6b2ccad29745: pmccontrol: improve -L with pmu-events
rG167cdaa7e300: pmccontrol: improve -L with pmu-events
Summary

Check if the action is supported rather than carrying a
machine-dependent #ifdef.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39541
Build 36430: arc lint + arc unit

Event Timeline

mhorne created this revision.May 28 2021, 6:08 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 28 2021, 6:08 PM
mhorne requested review of this revision.May 28 2021, 6:08 PM
Harbormaster completed remote builds in B39541: Diff 90064.May 28 2021, 6:08 PM
emaste added inline comments.May 28 2021, 6:15 PM
usr.sbin/pmccontrol/pmccontrol.c
295

This (pmc_pmu_print_counters) is an empty fn on non-x86?

mhorne added inline comments.May 28 2021, 6:20 PM
usr.sbin/pmccontrol/pmccontrol.c
295

For now, yes, but soon it won't be. However, pmc_pmu_enabled() will return false on those platforms.

emaste accepted this revision.May 28 2021, 6:35 PM
This revision is now accepted and ready to land.May 28 2021, 6:35 PM
gnn accepted this revision.May 28 2021, 7:08 PM
ray accepted this revision.May 28 2021, 10:32 PM
Closed by commit rG167cdaa7e300: pmccontrol: improve -L with pmu-events (authored by mhorne). · Explain WhyMay 31 2021, 8:40 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG167cdaa7e300: pmccontrol: improve -L with pmu-events.
mhorne added a commit: rG6b2ccad29745: pmccontrol: improve -L with pmu-events.Jul 29 2021, 3:27 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
pmccontrol/
16 lines

Diff 90064

View Options

usr.sbin/pmccontrol/pmccontrol.c

Loading...