Differential D30469

getnetent(3): Add missing reentrant functions
ClosedPublic
Actions

Authored by fernape on May 26 2021, 2:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 12, 10:50 PM

	Unknown Object (File)
	Mon, Aug 10, 10:25 AM

	Unknown Object (File)
	Mon, Aug 10, 9:58 AM

	Unknown Object (File)
	Mon, Aug 10, 3:59 AM

	Unknown Object (File)
	Sat, Aug 8, 12:54 AM

	Unknown Object (File)
	Mon, Aug 3, 4:04 PM

	Unknown Object (File)
	Sun, Jul 26, 3:49 AM

	Unknown Object (File)
	Tue, Jul 21, 9:31 PM

Subscribers

pauamma_chezdork.com

Details

Reviewers

0mp
gbe
imp
pauamma_chezdork.com

Group Reviewers

Commits

rGa3c3c02244f4: getnetent(3): Add missing reentrant functions
rGdc68997328ec: getnetent(3): Add missing reentrant functions

Summary

Add documentation for getnetent_r, getnetbyaddr_r and getnetbyname_r

Create proper MLINKs for the new functions.

PR: 249154
Reported by: asomers@

Test Plan

Same as in https://reviews.freebsd.org/D30385

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39463
Build 36352: arc lint + arc unit

Event Timeline

fernape created this revision.May 26 2021, 2:40 PM

Herald added a reviewer: manpages. · View Herald TranscriptMay 26 2021, 2:40 PM

Herald added a subscriber: imp. · View Herald Transcript

fernape requested review of this revision.May 26 2021, 2:40 PM

Harbormaster completed remote builds in B39463: Diff 89909.May 26 2021, 2:40 PM

Add .Nm entries.

Harbormaster completed remote builds in B45958: Diff 106867.Jun 13 2022, 4:02 PM

Can I have some feedback here so I can move forward with this?

same, seems reasonable

This revision is now accepted and ready to land.Jun 13 2022, 8:28 PM

pauamma_chezdork.com added a subscriber: pauamma_chezdork.com.Jun 16 2022, 12:15 AM

pauamma_chezdork.com added inline comments.

lib/libc/net/gethostbyname.3
43–45 ↗	(On Diff #106867)	Should all the *_r functions be kept together, or each moved next to the corresponding non-reentrant function?
68–73 ↗	(On Diff #106867)	Same question as above.

fernape added inline comments.Jun 16 2022, 6:04 AM

lib/libc/net/gethostbyname.3
43–45 ↗	(On Diff #106867)	I would keep them together. See cap_endgrent(3), cap_pwd(3)

pauamma_chezdork.com accepted this revision.Jun 17 2022, 4:10 AM

pauamma_chezdork.com added inline comments.

lib/libc/net/gethostbyname.3
43–45 ↗	(On Diff #106867)	WFM. Consistency in outline with other manual pages is as good an answer as any.

Closed by commit rGdc68997328ec: getnetent(3): Add missing reentrant functions (authored by fernape). · Explain WhyJun 20 2022, 5:31 AM

This revision was automatically updated to reflect the committed changes.

fernape added a commit: rGdc68997328ec: getnetent(3): Add missing reentrant functions.

gbe added a commit: rGa3c3c02244f4: getnetent(3): Add missing reentrant functions.Sep 24 2022, 8:13 AM

Revision Contents
Changeset List

Path

Size

lib/

libc/

net/

4 lines

26 lines

Diff 89909

lib/libc/net/Makefile.inc

Loading...

lib/libc/net/getnetent.3

Loading...