Page MenuHomeFreeBSD
Differential D30397

Clean up some of the core dumping code.
ClosedPublic
Actions

Authored by trasz on May 22 2021, 9:12 AM.
Tags
None
Referenced Files
F134786972: D30397.id89823.diff
Tue, Nov 4, 3:15 PM
Unknown Object (File)
Sat, Nov 1, 5:13 AM
Unknown Object (File)
Fri, Oct 31, 1:27 AM
Unknown Object (File)
Wed, Oct 29, 9:27 AM
Unknown Object (File)
Wed, Oct 29, 9:25 AM
Unknown Object (File)
Wed, Oct 29, 9:23 AM
Unknown Object (File)
Wed, Oct 29, 9:01 AM
Unknown Object (File)
Tue, Oct 28, 6:19 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
kib
Commits
rGbc0c8c4d0cea: Clean up some of the core dumping code.
rG3b9971c8da75: Clean up some of the core dumping code.
Summary

No functional changes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39439
Build 36328: arc lint + arc unit

Event Timeline

trasz created this revision.May 22 2021, 9:12 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 22 2021, 9:12 AM
trasz requested review of this revision.May 22 2021, 9:12 AM
Harbormaster completed remote builds in B39355: Diff 89649.May 22 2021, 9:12 AM
trasz mentioned this in D30369: Refactor core dumping code a bit.May 22 2021, 9:12 AM
kib accepted this revision.May 22 2021, 9:34 AM
kib added inline comments.
sys/kern/kern_exec.c
1992 ↗(On Diff #89649)

Cast is not needed, BTW.

This revision is now accepted and ready to land.May 22 2021, 9:34 AM
trasz updated this revision to Diff 89807.May 25 2021, 10:42 AM

Drop unnecessary cast.

This revision now requires review to proceed.May 25 2021, 10:42 AM
Harbormaster completed remote builds in B39437: Diff 89807.May 25 2021, 10:42 AM
trasz updated this revision to Diff 89809.May 25 2021, 10:46 AM

Sigh.

Herald added a subscriber: emaste. · View Herald TranscriptMay 25 2021, 10:46 AM
Harbormaster completed remote builds in B39439: Diff 89809.May 25 2021, 10:46 AM
trasz updated this revision to Diff 89810.May 25 2021, 10:46 AM

Arrgh.

Harbormaster completed remote builds in B39440: Diff 89810.May 25 2021, 10:46 AM
kib accepted this revision.May 25 2021, 12:02 PM
This revision is now accepted and ready to land.May 25 2021, 12:02 PM
Closed by commit rG3b9971c8da75: Clean up some of the core dumping code. (authored by trasz). · Explain WhyMay 25 2021, 3:31 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rG3b9971c8da75: Clean up some of the core dumping code..
jhb added a commit: rGbc0c8c4d0cea: Clean up some of the core dumping code..May 12 2022, 10:57 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux/
36 lines
46 lines
linux32/
26 lines
24 lines

Diff 89809

View Options

sys/amd64/linux/linux.h

Loading...
View Options

sys/amd64/linux/linux_ptrace.c

Loading...
View Options

sys/amd64/linux32/linux.h

Loading...
View Options

sys/amd64/linux32/linux32_machdep.c

Loading...