Page MenuHomeFreeBSD
Differential D30393

ktls.4: Remove an obsolete statement
ClosedPublic
Actions

Authored by markj on May 21 2021, 9:44 PM.
Tags
None
Referenced Files
F140972264: D30393.id54425.diff
Tue, Dec 30, 6:42 AM
Unknown Object (File)
Sat, Dec 27, 9:15 PM
Unknown Object (File)
Thu, Dec 4, 7:56 PM
Unknown Object (File)
Thu, Dec 4, 3:03 PM
Unknown Object (File)
Nov 14 2025, 10:16 PM
Unknown Object (File)
Nov 4 2025, 10:20 AM
Unknown Object (File)
Nov 4 2025, 10:20 AM
Unknown Object (File)
Nov 4 2025, 10:14 AM
View All Files
Subscribers
imp

Details

Reviewers
jhb
gallatin
Group Reviewers
manpages
Commits
rGb9fc1e9077ce: ktls.4: Remove an obsolete statement
rGc235059bb7e6: ktls.4: Remove an obsolete statement
Summary

The default mb_use_ext_pgs value was toggled in commit 52cd25eb1aa.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.May 21 2021, 9:44 PM
Herald added a reviewer: manpages. · View Herald TranscriptMay 21 2021, 9:44 PM
Herald added a subscriber: imp. · View Herald Transcript
markj requested review of this revision.May 21 2021, 9:44 PM
markj added a parent revision: D30392: ktls.h: Guard includes behind _KERNEL.
Harbormaster completed remote builds in B39349: Diff 89632.May 21 2021, 9:44 PM
jhb accepted this revision.May 22 2021, 12:23 AM

Hmm, not sure if we want to keep documenting the requirement and just omit the comment about them being off by default? Maybe it's not worth doing though.

This revision is now accepted and ready to land.May 22 2021, 12:23 AM
markj added a comment.May 22 2021, 4:11 PM
In D30393#682763, @jhb wrote:

Hmm, not sure if we want to keep documenting the requirement and just omit the comment about them being off by default? Maybe it's not worth doing though.

I'm not sure either. I feel like mb_use_ext_pgs is effectively a chicken switch, so I'm not sure there's much point in documenting it: if you changed it, you (hopefully) already know what you're doing.

Closed by commit rGc235059bb7e6: ktls.4: Remove an obsolete statement (authored by markj). · Explain WhyMay 22 2021, 4:18 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGc235059bb7e6: ktls.4: Remove an obsolete statement.
markj added a commit: rGb9fc1e9077ce: ktls.4: Remove an obsolete statement.May 12 2023, 6:16 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
8 lines

Diff 89663

View Options

share/man/man4/ktls.4

Loading...