Page MenuHomeFreeBSD
Differential D30393

ktls.4: Remove an obsolete statement
ClosedPublic
Actions

Authored by markj on May 21 2021, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 1:42 AM
Unknown Object (File)
Tue, Mar 18, 11:54 AM
Unknown Object (File)
Tue, Feb 25, 12:26 AM
Unknown Object (File)
Feb 16 2025, 3:05 PM
Unknown Object (File)
Feb 8 2025, 12:36 AM
Unknown Object (File)
Jan 26 2025, 6:11 PM
Unknown Object (File)
Jan 26 2025, 12:01 PM
Unknown Object (File)
Dec 5 2024, 2:03 AM
View All 58 Files
Subscribers
imp

Details

Reviewers
jhb
gallatin
Group Reviewers
manpages
Commits
rGb9fc1e9077ce: ktls.4: Remove an obsolete statement
rGc235059bb7e6: ktls.4: Remove an obsolete statement
Summary

The default mb_use_ext_pgs value was toggled in commit 52cd25eb1aa.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39349
Build 36238: arc lint + arc unit

Event Timeline

markj created this revision.May 21 2021, 9:44 PM
Herald added a reviewer: manpages. · View Herald TranscriptMay 21 2021, 9:44 PM
Herald added a subscriber: imp. · View Herald Transcript
markj requested review of this revision.May 21 2021, 9:44 PM
markj added a parent revision: D30392: ktls.h: Guard includes behind _KERNEL.
Harbormaster completed remote builds in B39349: Diff 89632.May 21 2021, 9:44 PM
jhb accepted this revision.May 22 2021, 12:23 AM

Hmm, not sure if we want to keep documenting the requirement and just omit the comment about them being off by default? Maybe it's not worth doing though.

This revision is now accepted and ready to land.May 22 2021, 12:23 AM
markj added a comment.May 22 2021, 4:11 PM
In D30393#682763, @jhb wrote:

Hmm, not sure if we want to keep documenting the requirement and just omit the comment about them being off by default? Maybe it's not worth doing though.

I'm not sure either. I feel like mb_use_ext_pgs is effectively a chicken switch, so I'm not sure there's much point in documenting it: if you changed it, you (hopefully) already know what you're doing.

Closed by commit rGc235059bb7e6: ktls.4: Remove an obsolete statement (authored by markj). · Explain WhyMay 22 2021, 4:18 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGc235059bb7e6: ktls.4: Remove an obsolete statement.
markj added a commit: rGb9fc1e9077ce: ktls.4: Remove an obsolete statement.May 12 2023, 6:16 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
8 lines

Diff 89632

View Options

share/man/man4/ktls.4

Show First 20 Lines • Show All 2,800 Lines • ▼ Show 20 Lines
VMM_STAT_FUNC(VMM_MEM_WIRED, "Wired memory", vm_get_wiredcnt); VMM_STAT_FUNC(VMM_MEM_WIRED, "Wired memory", vm_get_wiredcnt);
#ifdef BHYVE_SNAPSHOT #ifdef BHYVE_SNAPSHOT
static int static int
vm_snapshot_vcpus(struct vm *vm, struct vm_snapshot_meta *meta) vm_snapshot_vcpus(struct vm *vm, struct vm_snapshot_meta *meta)
{ {
uint64_t tsc, now; uint64_t tsc, now;
int ret; int ret;
int i;
struct vcpu *vcpu; struct vcpu *vcpu;
uint16_t i, maxcpus;
now = rdtsc(); now = rdtsc();
for (i = 0; i < VM_MAXCPU; i++) { maxcpus = vm_get_maxcpus(vm);
for (i = 0; i < maxcpus; i++) {
vcpu = &vm->vcpu[i]; vcpu = &vm->vcpu[i];
SNAPSHOT_VAR_OR_LEAVE(vcpu->x2apic_state, meta, ret, done); SNAPSHOT_VAR_OR_LEAVE(vcpu->x2apic_state, meta, ret, done);
SNAPSHOT_VAR_OR_LEAVE(vcpu->exitintinfo, meta, ret, done); SNAPSHOT_VAR_OR_LEAVE(vcpu->exitintinfo, meta, ret, done);
SNAPSHOT_VAR_OR_LEAVE(vcpu->exc_vector, meta, ret, done); SNAPSHOT_VAR_OR_LEAVE(vcpu->exc_vector, meta, ret, done);
SNAPSHOT_VAR_OR_LEAVE(vcpu->exc_errcode_valid, meta, ret, done); SNAPSHOT_VAR_OR_LEAVE(vcpu->exc_errcode_valid, meta, ret, done);
SNAPSHOT_VAR_OR_LEAVE(vcpu->exc_errcode, meta, ret, done); SNAPSHOT_VAR_OR_LEAVE(vcpu->exc_errcode, meta, ret, done);
SNAPSHOT_VAR_OR_LEAVE(vcpu->guest_xcr0, meta, ret, done); SNAPSHOT_VAR_OR_LEAVE(vcpu->guest_xcr0, meta, ret, done);
Show All 25 Lines
done: done:
return (ret); return (ret);
} }
static int static int
vm_snapshot_vmcx(struct vm *vm, struct vm_snapshot_meta *meta) vm_snapshot_vmcx(struct vm *vm, struct vm_snapshot_meta *meta)
{ {
int i, error; int error;
uint16_t i, maxcpus;
error = 0; error = 0;
for (i = 0; i < VM_MAXCPU; i++) { maxcpus = vm_get_maxcpus(vm);
for (i = 0; i < maxcpus; i++) {
error = vmmops_vmcx_snapshot(vm->cookie, meta, i); error = vmmops_vmcx_snapshot(vm->cookie, meta, i);
if (error != 0) { if (error != 0) {
printf("%s: failed to snapshot vmcs/vmcb data for " printf("%s: failed to snapshot vmcs/vmcb data for "
"vCPU: %d; error: %d\n", __func__, i, error); "vCPU: %d; error: %d\n", __func__, i, error);
goto done; goto done;
} }
} }
▲ Show 20 Lines • Show All 48 Lines • ▼ Show 20 Linesvm_snapshot_req(struct vm *vm, struct vm_snapshot_meta *meta)
return (ret); return (ret);
} }
int int
vm_set_tsc_offset(struct vm *vm, int vcpuid, uint64_t offset) vm_set_tsc_offset(struct vm *vm, int vcpuid, uint64_t offset)
{ {
struct vcpu *vcpu; struct vcpu *vcpu;
if (vcpuid < 0 || vcpuid >= VM_MAXCPU) if (vcpuid < 0 || vcpuid >= vm_get_maxcpus(vm))
return (EINVAL); return (EINVAL);
vcpu = &vm->vcpu[vcpuid]; vcpu = &vm->vcpu[vcpuid];
vcpu->tsc_offset = offset; vcpu->tsc_offset = offset;
return (0); return (0);
} }
int int
vm_restore_time(struct vm *vm) vm_restore_time(struct vm *vm)
{ {
int error, i; int error;
uint64_t now; uint64_t now;
struct vcpu *vcpu; struct vcpu *vcpu;
uint16_t i, maxcpus;
now = rdtsc(); now = rdtsc();
error = vhpet_restore_time(vm_hpet(vm)); error = vhpet_restore_time(vm_hpet(vm));
if (error) if (error)
return (error); return (error);
for (i = 0; i < nitems(vm->vcpu); i++) { maxcpus = vm_get_maxcpus(vm);
for (i = 0; i < maxcpus; i++) {
vcpu = &vm->vcpu[i]; vcpu = &vm->vcpu[i];
error = vmmops_restore_tsc(vm->cookie, i, vcpu->tsc_offset - error = vmmops_restore_tsc(vm->cookie, i, vcpu->tsc_offset -
now); now);
if (error) if (error)
return (error); return (error);
} }
return (0); return (0);
} }
#endif #endif