Page MenuHomeFreeBSD

dummynet: Fix schedlist and aqmlist locking
ClosedPublic

Authored by kp on May 21 2021, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 1:23 PM
Unknown Object (File)
May 29 2024, 11:26 AM
Unknown Object (File)
May 26 2024, 1:21 AM
Unknown Object (File)
May 20 2024, 2:00 PM
Unknown Object (File)
May 19 2024, 9:27 PM
Unknown Object (File)
May 18 2024, 1:38 AM
Unknown Object (File)
May 16 2024, 9:52 AM
Unknown Object (File)
May 4 2024, 6:16 PM

Details

Summary

These are global (i.e. shared across vnets) structures, so we need
global lock to protect them. However, we look up entries in these lists
(find_aqm_type(), find_sched_type()) and return them. We must ensure
that the returned structures cannot go away while we are using them.

Resolve this by using NET_EPOCH(). The structures can be safely accessed
under it, and we postpone their cleanup until we're sure they're no
longer used.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39337
Build 36226: arc lint + arc unit

Event Timeline

kp requested review of this revision.May 21 2021, 3:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2021, 3:20 PM
This revision was automatically updated to reflect the committed changes.