Page MenuHomeFreeBSD
Differential D30272

ldconfig(8): update manpage to reality
ClosedPublic
Actions

Authored by kib on May 15 2021, 5:16 AM.
Tags
Referenced Files
Unknown Object (File)
Mon, Nov 18, 5:39 PM
Unknown Object (File)
Thu, Nov 14, 4:10 AM
Unknown Object (File)
Sun, Nov 3, 10:59 AM
Unknown Object (File)
Oct 18 2024, 3:47 PM
Unknown Object (File)
Oct 17 2024, 10:03 AM
Unknown Object (File)
Oct 5 2024, 6:03 AM
Unknown Object (File)
Oct 4 2024, 3:44 PM
Unknown Object (File)
Oct 4 2024, 8:42 AM
View All Files
Subscribers
bcr
yuri

Details

Reviewers
emaste
dim
Group Reviewers
manpages
Commits
rGa19e14ca2d36: ldconfig(8): update manpage to reality
Summary

ELF ldconfig only maintains the search list, there is no hints

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.May 15 2021, 5:16 AM
kib created this revision.
kib added a reviewer: manpages.
bcr added a subscriber: bcr.May 15 2021, 9:35 AM

A few minor nits, the rest looks fine.

sbin/ldconfig/ldconfig.8
51–64

s/configure set/configure a set/

126

s/directoriesf/directories/

kib updated this revision to Diff 89270.May 15 2021, 7:17 PM
kib marked 2 inline comments as done.

Grammar/typo.

yuri added a subscriber: yuri.EditedMay 16 2021, 2:51 PM

The new version doesn't mention what is the limitation on shared library names.

Normally they are:

libXx.so -> libXx.so.A
libXx.so.A -> libXx.so.A.B.C
libXx.so.A.B.C

but is this also allowed?:

libXx.so -> libXx.so.A.B
libXx.so.A.B -> libXx.so.A.B.C
libXx.so.A.B.C
kib added a comment.May 16 2021, 3:05 PM
In D30272#680344, @yuri wrote:

The new version doesn't mention what is the limitation on shared library names.

Normally they are:

libXx.so -> libXx.so.A
libXx.so.A -> libXx.so.A.B.C
libXx.so.A.B.C

but is this also allowed?:

libXx.so -> libXx.so.A.B
libXx.so.A.B -> libXx.so.A.B.C
libXx.so.A.B.C

New version is quite explicit that ldconfig does not care about libraries or libraries names at all.

yuri added a comment.May 16 2021, 3:09 PM
In D30272#680345, @kib wrote:

New version is quite explicit that ldconfig does not care about libraries or libraries names at all.

Ok

emaste added inline comments.May 19 2021, 2:10 PM
sbin/ldconfig/ldconfig.8
6

Portions of this documentation were written by

51–65

maybe

.Nm
utility is used to configure the set of paths used by the dynamic linker
.Xr ld-elf.so.1 1
when searching for shared libraries.

85–86

I'm not sure we need to keep this text at all - "the shared libraries which are found" implies we are building a list at ldconfig time?

89

additional shared library search directories.

113

Are they printed?

126

-r also performs a search and prints the libraries found?

144–145

should this perhaps be "only load shared libraries from paths found in the hints file"?

kib updated this revision to Diff 89475.May 19 2021, 2:53 PM
kib marked 7 inline comments as done.

Handle Ed' notes.

kib updated this revision to Diff 89483.May 19 2021, 9:05 PM

More editing, remove "line 76".

emaste accepted this revision.May 21 2021, 4:26 PM

Big improvement overall, thanks for cleaning up after my a.out removal change. One little note inline, but we can iterate on it in the tree etc. later on.

sbin/ldconfig/ldconfig.8
56–59

IMO we don't really need this either - for someone unfamiliar with the history of a.out this seems like we're telling them that they don't need to do something that they wouldn't anyway. But not a big deal.

This revision is now accepted and ready to land.May 21 2021, 4:26 PM
kib marked an inline comment as done.May 21 2021, 4:50 PM
kib added inline comments.
sbin/ldconfig/ldconfig.8
56–59

Mmm, no, this does not have anything to do with a.out. It is about -rpath (actually ELF feature, I do not remember anything similar in Sun 4.x/FreeBSD a.out so).

Closed by commit rGa19e14ca2d36: ldconfig(8): update manpage to reality (authored by kib). · Explain WhyMay 21 2021, 4:52 PM
This revision was automatically updated to reflect the committed changes.
kib marked an inline comment as done.
kib added a commit: rGa19e14ca2d36: ldconfig(8): update manpage to reality.

Revision Contents
Changeset List

PathSize
sbin/
ldconfig/
114 lines

Diff 89483

View Options

sbin/ldconfig/ldconfig.8

Loading...