Differential D3734

Allow @sample to take arguments
ClosedPublic
Actions

Authored by bapt on Sep 26 2015, 10:29 AM.

Details

Reviewers

antoine

Group Reviewers

portmgr

Commits

rP397963: Extend @sample to accept arguments

Summary

No changes for @sample bla.conf.sample
Offer a new syntax possible

@sample file1 file2
file1 is the sample file
file2 isi the target file

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 611
Build 611: arc lint + arc unit

Event Timeline

bapt updated this revision to Diff 8941.Sep 26 2015, 10:29 AM

bapt retitled this revision from to Allow @sample to take arguments.

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

bapt added a reviewer: portmgr.

Mk/Scripts/functions.sh must be adjusted to handle this

Adapt the shell plist parser

Herald edited edge metadata. · View Herald TranscriptSep 26 2015, 11:30 AM

looks good to me (with the set -x removed)

This revision is now accepted and ready to land.Sep 26 2015, 11:57 AM

Closed by commit rP397963: Extend @sample to accept arguments (authored by bapt). · Explain WhySep 26 2015, 12:13 PM

This revision was automatically updated to reflect the committed changes.

How does it work if the filename contains a whitespace character ?

In D3734#77149, @mat wrote:

How does it work if the filename contains a whitespace character ?

You will have to escape like in shell:
"my file" or my\ file

Revision Contents
Changeset List

Path

Size

Keywords/

sample.ucl

33 lines

Mk/

Scripts/

functions.sh

25 lines

Diff 8942

View Options

Keywords/sample.ucl