Page MenuHomeFreeBSD

Allow @sample to take arguments
ClosedPublic

Authored by bapt on Sep 26 2015, 10:29 AM.

Details

Summary

No changes for @sample bla.conf.sample
Offer a new syntax possible

@sample file1 file2
file1 is the sample file
file2 isi the target file

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bapt updated this revision to Diff 8941.Sep 26 2015, 10:29 AM
bapt retitled this revision from to Allow @sample to take arguments.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: portmgr.

Mk/Scripts/functions.sh must be adjusted to handle this

bapt updated this revision to Diff 8942.Sep 26 2015, 11:30 AM

Adapt the shell plist parser

antoine accepted this revision.Sep 26 2015, 11:57 AM
antoine added a reviewer: antoine.

looks good to me (with the set -x removed)

This revision is now accepted and ready to land.Sep 26 2015, 11:57 AM
This revision was automatically updated to reflect the committed changes.
mat added a subscriber: mat.Sep 27 2015, 9:00 AM

How does it work if the filename contains a whitespace character ?

bapt added a comment.Sep 27 2015, 9:20 AM
In D3734#77149, @mat wrote:

How does it work if the filename contains a whitespace character ?

You will have to escape like in shell:
"my file" or my\ file