Page MenuHomeFreeBSD
Differential D30122

sdhci_fsl_fdt.c: Add a missing call to mmc_fdt_parse.
ClosedPublic
Actions

Authored by lha_semihalf.com on May 5 2021, 2:00 PM.
Tags
None
Referenced Files
F158872884: D30122.diff
Sun, Jun 7, 3:27 AM
Unknown Object (File)
Thu, May 21, 8:29 PM
Unknown Object (File)
Sat, May 9, 6:27 AM
Unknown Object (File)
May 3 2026, 12:53 AM
Unknown Object (File)
Apr 29 2026, 1:20 AM
Unknown Object (File)
Apr 28 2026, 10:27 PM
Unknown Object (File)
Apr 28 2026, 10:24 PM
Unknown Object (File)
Apr 28 2026, 6:58 PM
View All Files
Subscribers
kd

Details

Reviewers
mw
ar_semihalf.com
manu
mmel
Commits
rGf0a9d7d79956: sdhci_fsl_fdt.c: Add a missing call to mmc_fdt_parse.
Summary

Add a missing call to mmc_fdt_parse, without it some dts properties
are not parsed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lha_semihalf.com requested review of this revision.May 5 2021, 2:00 PM
lha_semihalf.com created this revision.
lha_semihalf.com added a parent revision: D30123: sdhci_fsl_fdt.c: Read supported voltages from dts..
lha_semihalf.com removed a parent revision: D30123: sdhci_fsl_fdt.c: Read supported voltages from dts..
lha_semihalf.com added a child revision: D30123: sdhci_fsl_fdt.c: Read supported voltages from dts..May 5 2021, 2:02 PM
lha_semihalf.com added a parent revision: D30121: sdhci_fsl_fdt.c: Add support for LS1028a..
manu added a comment.May 5 2021, 3:41 PM

Now they are parsed but you don't use them.
See https://cgit.freebsd.org/src/commit/sys/arm/allwinner/aw_mmc.c?id=9ed8321078444aea2a90a361f91e54065d5daf21 for how to use it.

lha_semihalf.com added a comment.May 7 2021, 7:23 AM

You are right, I am working on using parsed values and will update this patch next week probably.

lha_semihalf.com updated this revision to Diff 88939.May 10 2021, 11:52 AM

Implement usage of values parsed from fdt, add support for max-frequency property.

mw accepted this revision.May 13 2021, 8:12 AM
This revision is now accepted and ready to land.May 13 2021, 8:12 AM
manu accepted this revision.May 13 2021, 8:22 AM
Closed by commit rGf0a9d7d79956: sdhci_fsl_fdt.c: Add a missing call to mmc_fdt_parse. (authored by mw). · Explain WhyMay 14 2021, 8:53 AM
This revision was automatically updated to reflect the committed changes.
mw added a commit: rGf0a9d7d79956: sdhci_fsl_fdt.c: Add a missing call to mmc_fdt_parse..

Revision Contents
Changeset List

PathSize
sys/
dev/
sdhci/
110 lines

Diff 88939

View Options

sys/dev/sdhci/sdhci_fsl_fdt.c

Loading...