Page MenuHomeFreeBSD
Differential D30024

linuxkpi: Introduce tasklet_disable_nosync()
ClosedPublic
Actions

Authored by nc on Apr 28 2021, 11:41 AM.
Tags
None
Referenced Files
F163192766: D30024.id88314.diff
Mon, Jul 20, 10:28 PM
Unknown Object (File)
Mon, Jul 20, 12:20 AM
Unknown Object (File)
Mon, Jul 13, 5:50 PM
Unknown Object (File)
Mon, Jul 6, 4:40 AM
Unknown Object (File)
Sat, Jul 4, 7:56 PM
Unknown Object (File)
Sat, Jul 4, 8:26 AM
Unknown Object (File)
Sat, Jul 4, 7:39 AM
Unknown Object (File)
Sat, Jul 4, 6:59 AM
View All Files
Subscribers
emaste
• hselasky
imp
manu
linuxkpi

Details

Reviewers
manu
• hselasky
Commits
rG1fbf4377a410: linuxkpi: Introduce tasklet_disable_nosync()
rG9781105bea58: linuxkpi: Introduce tasklet_disable_nosync()
Summary

This is needed for the drm-kmod 5.5 update.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38910
Build 35799: arc lint + arc unit

Event Timeline

nc created this revision.Apr 28 2021, 11:41 AM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptApr 28 2021, 11:41 AM
nc requested review of this revision.Apr 28 2021, 11:41 AM
Harbormaster completed remote builds in B38901: Diff 88305.Apr 28 2021, 11:41 AM
• hselasky added inline comments.Apr 28 2021, 12:32 PM
sys/compat/linuxkpi/common/include/linux/interrupt.h
205

Implement this as a regular external function, see tasklet_disable() below.

This avoids header file pollution, that you need to depend on including atomic.h .

nc updated this revision to Diff 88311.Apr 28 2021, 12:46 PM

Add @hselasky's requestd updates.

Harbormaster completed remote builds in B38904: Diff 88311.Apr 28 2021, 12:46 PM
nc updated this revision to Diff 88314.Apr 28 2021, 12:59 PM

Fix compilation issues.

Harbormaster completed remote builds in B38907: Diff 88314.Apr 28 2021, 1:00 PM
• hselasky added inline comments.Apr 28 2021, 1:03 PM
sys/compat/linuxkpi/common/src/linux_tasklet.c
66

No need for this define. Just inline it.

nc updated this revision to Diff 88323.Apr 28 2021, 2:12 PM

Inline the function.

Harbormaster completed remote builds in B38910: Diff 88323.Apr 28 2021, 2:12 PM
nc updated this revision to Diff 88326.Apr 28 2021, 2:17 PM

Forgot to push my changes, sorry.

Harbormaster completed remote builds in B38912: Diff 88326.Apr 28 2021, 2:17 PM
• hselasky accepted this revision.Apr 28 2021, 2:35 PM
This revision is now accepted and ready to land.Apr 28 2021, 2:35 PM
• hselasky added inline comments.Apr 28 2021, 2:36 PM
sys/compat/linuxkpi/common/src/linux_tasklet.c
36

I think this include is not needed.

nc updated this revision to Diff 88329.Apr 28 2021, 2:58 PM

Thanks for pointing out. Here's an updated diff.

This revision now requires review to proceed.Apr 28 2021, 2:58 PM
Harbormaster completed remote builds in B38913: Diff 88329.Apr 28 2021, 2:58 PM
• hselasky accepted this revision.Apr 28 2021, 2:59 PM
This revision is now accepted and ready to land.Apr 28 2021, 2:59 PM
Closed by commit rG9781105bea58: linuxkpi: Introduce tasklet_disable_nosync() (authored by nc). · Explain WhyApr 28 2021, 3:07 PM
This revision was automatically updated to reflect the committed changes.
nc added a commit: rG9781105bea58: linuxkpi: Introduce tasklet_disable_nosync().
nc added a commit: rG1fbf4377a410: linuxkpi: Introduce tasklet_disable_nosync().May 1 2021, 12:57 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
1 line
src/
10 lines

Diff 88323

View Options

sys/compat/linuxkpi/common/include/linux/interrupt.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_tasklet.c

Loading...