Page MenuHomeFreeBSD
Differential D29783

bridge tests: Test STP config BPDU validation
ClosedPublic
Actions

Authored by kp on Apr 15 2021, 5:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 11, 1:29 AM
Unknown Object (File)
Nov 27 2025, 12:21 AM
Unknown Object (File)
Nov 25 2025, 5:14 PM
Unknown Object (File)
Nov 21 2025, 7:20 AM
Unknown Object (File)
Nov 20 2025, 4:09 AM
Unknown Object (File)
Nov 16 2025, 12:25 PM
Unknown Object (File)
Nov 16 2025, 5:43 AM
Unknown Object (File)
Nov 15 2025, 10:33 PM
View All Files
Subscribers
ae
donner
imp
melifaro

Details

Reviewers
donner
Group Reviewers
network
Commits
rGad27abda399a: bridge tests: Test STP config BPDU validation
rGe8889c723a81: bridge tests: Test STP config BPDU validation
rG4ae3a97e127c: bridge tests: Test STP config BPDU validation
Summary

PR: 254924

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningtests/sys/net/if_bridge_test.sh:CHMOD1Invalid Executable
Unit
No Test Coverage
Build Status
Buildable 38646
Build 35535: arc lint + arc unit

Event Timeline

kp created this revision.Apr 15 2021, 5:35 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptApr 15 2021, 5:35 PM
kp requested review of this revision.Apr 15 2021, 5:35 PM
Harbormaster completed remote builds in B38602: Diff 87504.Apr 15 2021, 5:35 PM
donner accepted this revision as: donner.Apr 15 2021, 8:10 PM
donner added a subscriber: donner.

May you please add tests for the edge cases where the number is exactly the limit?
Thanks.

This revision is now accepted and ready to land.Apr 15 2021, 8:10 PM
kp updated this revision to Diff 87616.Apr 17 2021, 2:45 PM
  • Use just barely invalid values
  • Ignore valid STP packets (which if_bridge might send during the test)
This revision now requires review to proceed.Apr 17 2021, 2:45 PM
Harbormaster completed remote builds in B38646: Diff 87616.Apr 17 2021, 2:46 PM
donner accepted this revision as: donner.Apr 18 2021, 9:43 AM
This revision is now accepted and ready to land.Apr 18 2021, 9:43 AM
This revision was landed with ongoing or failed builds.Apr 19 2021, 12:11 PM
Closed by commit rG4ae3a97e127c: bridge tests: Test STP config BPDU validation (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG4ae3a97e127c: bridge tests: Test STP config BPDU validation.
kp added a commit: rGe8889c723a81: bridge tests: Test STP config BPDU validation.May 18 2021, 12:20 PM
kp added a commit: rGad27abda399a: bridge tests: Test STP config BPDU validation.

Revision Contents
Changeset List

PathSize
tests/
sys/
net/
7 lines
45 lines
112 lines

Diff 87616

View Options

tests/sys/net/Makefile

Loading...
View Options

tests/sys/net/if_bridge_test.sh

Loading...
View Options

tests/sys/net/stp.py

Loading...