This type mirrors struct sge_ofld_rxq and holds state for TCP offload
transmit queues. Currently it only holds a work queue but will
include additional state in future changes.
Sponsored by: Chelsio Communications
Details
Details
- Reviewers
np - Commits
- rG077ba6a845fa: cxgbe: Add a struct sge_ofld_txq type.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 38072 Build 34961: arc lint + arc unit
Event Timeline
Comment Actions
The offload tx queues are also used for RATELIMIT tx and we should either set cxgbe_rate_tag->eo_txq to ofld_txq->wrq in ethofld_transmit or change eo_txq to be a sge_ofld_txq.
Comment Actions
There's also this in t4_main.c that needs to be updated to sizeof(struct sge_ofld_txq):
s->ofld_txq = malloc(s->nofldtxq * sizeof(struct sge_wrq), M_CXGBE, M_ZERO | M_WAITOK);
| sys/dev/cxgbe/t4_main.c | ||
|---|---|---|
| 1334 | Using 'sizeof(*s->ofld_txq)' here instead of the type would perhaps have been more future proof. | |
| sys/dev/cxgbe/t4_sge.c | ||
| 6447 | I changed the type of cst->eo_txq so that this line would still work (and it also seemed more natural for eo_txq to point to the actual txq rather than just the embedded wrq). | |