Page MenuHomeFreeBSD
Differential D29356

Tune DTrace 'aframes' for the FBT and profile providers on arm64.
ClosedPublic
Actions

Authored by rwatson on Mar 21 2021, 12:08 AM.
Tags
None
Referenced Files
F160373143: D29356.diff
Tue, Jun 23, 8:33 PM
F160362077: D29356.id86090.diff
Tue, Jun 23, 5:11 PM
Unknown Object (File)
Tue, Jun 23, 6:51 AM
Unknown Object (File)
Tue, Jun 23, 2:39 AM
Unknown Object (File)
Mon, Jun 22, 4:28 PM
Unknown Object (File)
Sun, Jun 21, 5:15 PM
Unknown Object (File)
Tue, Jun 9, 12:16 PM
Unknown Object (File)
Wed, Jun 3, 3:19 AM
View All Files
Subscribers
allanjude
andrew
emaste
imp

Details

Reviewers
andrew
emaste
Group Reviewers
DTrace
ARM
Commits
rG7745d7159777: Tune DTrace 'aframes' for the FBT and profile providers on arm64.
rGfcc700abe4fa: Tune DTrace 'aframes' for the FBT and profile providers on arm64.
Summary

In both cases, too few frames were trimmed, leading to exception handling
or DTrace internals being exposed in stack traces exposed by D's stack()
primitive.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rwatson created this revision.Mar 21 2021, 12:08 AM
Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptMar 21 2021, 12:08 AM
rwatson requested review of this revision.Mar 21 2021, 12:08 AM
Harbormaster completed remote builds in B37969: Diff 86090.Mar 21 2021, 12:08 AM
rwatson added a reviewer: DTrace.Mar 21 2021, 12:08 AM
rwatson added a subscriber: allanjude.
rwatson added a reviewer: ARM.Mar 21 2021, 1:43 PM
andrew accepted this revision.Mar 22 2021, 9:30 AM
This revision is now accepted and ready to land.Mar 22 2021, 9:30 AM
emaste removed a reviewer: andrew.Mar 22 2021, 2:31 PM
emaste added inline comments.
sys/cddl/dev/profile/profile.c
107

I deleted this and the sparc comment above in 64a790d264808116469914c19265e905b3929e00, thinking that this change had already been committed. In any case this shouldn't be a conflict.

This revision now requires review to proceed.Mar 22 2021, 2:31 PM
andrew accepted this revision.Mar 22 2021, 2:58 PM
andrew added inline comments.
sys/cddl/dev/profile/profile.c
117

There is also a duplicate __mips that could be removed after this has been committed

133

Here

This revision is now accepted and ready to land.Mar 22 2021, 2:58 PM
emaste accepted this revision.Mar 22 2021, 4:26 PM
Closed by commit rGfcc700abe4fa: Tune DTrace 'aframes' for the FBT and profile providers on arm64. (authored by rwatson, committed by emaste). · Explain WhyMar 25 2021, 1:19 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGfcc700abe4fa: Tune DTrace 'aframes' for the FBT and profile providers on arm64..
emaste added a commit: rG7745d7159777: Tune DTrace 'aframes' for the FBT and profile providers on arm64..Mar 31 2021, 4:07 PM

Revision Contents
Changeset List

PathSize
sys/
cddl/
dev/
fbt/
aarch64/
5 lines
profile/
3 lines

Diff 86305

View Options

sys/cddl/dev/fbt/aarch64/fbt_isa.c

Loading...
View Options

sys/cddl/dev/profile/profile.c

Loading...