julia10
AbandonedPublic
Actions

Authored by lwhsu on Mar 21 2021, 11:29 AM.

Details

Reviewers

iblis.dif01_nctu.edu.tw
nyan_myuji.xyz

Summary

lang/julia and lang/julia10 was removed from ports as it uses python2.7,
this patch make them use python3.6+ and bring them back to ports

Test Plan

poudriere: testport succeed on 12.2-release

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 37971
Build 34860: arc lint + arc unit

Event Timeline

nyan_myuji.xyz created this revision.Mar 21 2021, 11:29 AM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptMar 21 2021, 11:29 AM

nyan_myuji.xyz requested review of this revision.Mar 21 2021, 11:29 AM

Harbormaster completed remote builds in B37970: Diff 86100.Mar 21 2021, 11:29 AM

remove lang/julia and lang/juila10 from MOVED

Harbormaster completed remote builds in B37971: Diff 86101.Mar 21 2021, 11:31 AM

nyan_myuji.xyz added a reviewer: lwhsu.Mar 21 2021, 12:15 PM

thierry added a subscriber: thierry.Mar 21 2021, 12:38 PM

Thanks for resurrecting julia!

I have two remarks:

any reason to work on 1.0.3? The latest release is now 1.5.4, and 1.6.0 is now at -rc3;
when using the external BLAS, you could set USES+= blaslapack:openblas

lwhsu added a reviewer: iblis.dif01_nctu.edu.tw.Mar 21 2021, 1:30 PM

In D29359#657456, @thierry wrote:

Thanks for resurrecting julia!

I have two remarks:

any reason to work on 1.0.3? The latest release is now 1.5.4, and 1.6.0 is now at -rc3;

when using the external BLAS, you could set USES+= blaslapack:openblas

The port is actually 1.0.5, the latest release is indeed 1.5.4 but the LTS version is at 1.0.5. I haven't got time yet to port the latest version over but I figure I can bring the LTS version back first.
For BLAS, since the original port works well therefore I think I'd just keep it as is.

iblis.dif01_nctu.edu.tw added inline comments.Apr 12 2021, 2:05 AM

lang/julia10/Makefile
70	Could you change the `OPENLIBM` to `SYSLIBM` as default option? kargl@ suggests that switching back to system libm as default (or just removing the openlibm knob) since there are some issues on i386 platform (https://github.com/JuliaMath/openlibm/issues/205, https://github.com/JuliaMath/openlibm/issues/206). And these issues have been fixed by system libm.

iblis.dif01_nctu.edu.tw added inline comments.Apr 12 2021, 2:36 AM

lang/julia/Makefile
5–6
lang/julia10/Makefile
93	Not sure why we need this?

Perhaps we can bring JULIA_DEFAULT back also? (It has been removed in https://reviews.freebsd.org/R11:12ec26904cd2f3c9093d5b3f4b07c71f0dbf30b9)

when using the external BLAS, you could set USES+= blaslapack:openblas

Ah, I didn't discover that knob before. Let's use it.

mat added inline comments.Apr 12 2021, 1:41 PM

lang/julia/Makefile
8–10	Something wrong with `USES=metaport`?
lang/julia10/Makefile
5
19–30	This is badly ordered, order is EXTRACT/BUILD/LIB.
112	This is at the wrong place, should be way up.
126–132	This does not actually need to be guarded by the openblas option.