Page MenuHomeFreeBSD
Differential D29033

wlandebug.8: remove Xref for missing manpages
ClosedPublic
Actions

Authored by fernape on Mar 3 2021, 7:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 12:20 PM
Unknown Object (File)
Tue, Nov 19, 4:41 PM
Unknown Object (File)
Tue, Nov 19, 4:34 PM
Unknown Object (File)
Tue, Nov 19, 2:38 PM
Unknown Object (File)
Oct 2 2024, 12:08 PM
Unknown Object (File)
Oct 1 2024, 10:07 AM
Unknown Object (File)
Oct 1 2024, 6:16 AM
Unknown Object (File)
Sep 27 2024, 5:57 PM
View All 64 Files
Subscribers
adrian
imp

Details

Reviewers
0mp
gbe
adrian
Group Reviewers
manpages
Commits
rG16b2290447de: wlandebug.8: remove Xref for missing manpages
Summary

PR: 227174

Remove references for: athdebug(8), athstats(8) and wlanstats(8)

Those are tools in the tools/ directory that are not built as part of the base
system. According to the tools/README file:

"...these tools are not meant to be built as part of the standard system..."

It does not make sense to reference manpages that are not included in the base
system.

Even more, the tools/tools/README' is not udpated and wlanstats` does not even
build on current:

error: cast from 'struct sockaddr *' to 'const struct sockaddr_dl *' increases
required alignment from 1 to 2 [-Werror,-Wcast-align]
Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./wlandebug.8 renders the page properly

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fernape created this revision.Mar 3 2021, 7:02 AM
Herald added a reviewer: manpages. · View Herald TranscriptMar 3 2021, 7:02 AM
Herald added a subscriber: imp. · View Herald Transcript
fernape requested review of this revision.Mar 3 2021, 7:02 AM
Harbormaster completed remote builds in B37526: Diff 85039.Mar 3 2021, 7:02 AM
gbe accepted this revision.Mar 3 2021, 7:35 PM
gbe added a subscriber: adrian.

LGTM from my side. @adrian, would you be fine with this change?

This revision is now accepted and ready to land.Mar 3 2021, 7:35 PM
fernape added a comment.Mar 10 2021, 1:56 PM
In D29033#650306, @gbe wrote:

LGTM from my side. @adrian, would you be fine with this change?

Hi @adrian, I will timeout this one soon unless you see any objections ;-)

adrian accepted this revision.Mar 14 2021, 6:17 PM

i mean, ok, until i move them into base proper :-P

Closed by commit rG16b2290447de: wlandebug.8: remove Xref for missing manpages (authored by fernape). · Explain WhyMar 15 2021, 9:11 AM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rG16b2290447de: wlandebug.8: remove Xref for missing manpages.
fernape added a comment.Mar 15 2021, 9:11 AM
In D29033#655137, @adrian wrote:

i mean, ok, until i move them into base proper :-P

Thanks for reviewing this!

Revision Contents
Changeset List

PathSize
usr.sbin/
wlandebug/
10 lines

Diff 85762

View Options

usr.sbin/wlandebug/wlandebug.8

Loading...