altq: Increase maximum number of CBQ and HFSC classes
ClosedPublic
Actions

Authored by kp on Mar 3 2021, 11:07 AM.

Details

Reviewers

Group Reviewers

Commits

rG2e2e51f15ae5: altq: Increase maximum number of CBQ and HFSC classes
rGbc98489262fb: altq: Increase maximum number of CBQ and HFSC classes
rG448732b8e2d9: altq: Increase maximum number of CBQ and HFSC classes

Summary

In some configurations we need more classes than ALTQ supports by
default. Increase the maximum number of classes we allow.
This will only cost us a comparatively trivial amount of memory, so
there's little reason not to do so.

If ever we find we want even more we may want to consider turning these
defines into a tunable, but for now do the easy thing.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Mar 3 2021, 11:07 AM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptMar 3 2021, 11:07 AM

Harbormaster completed remote builds in B37532: Diff 85046.Mar 3 2021, 11:07 AM

kp requested review of this revision.Mar 3 2021, 11:07 AM

How common is this requirement?
For normal production the customer is able to set the values manually before compiling.
I don't assume they will wait 3 week before having it in STABLE and some months to have it in RELEASE.

In D29034#650129, @donner wrote:

How common is this requirement?

I have no idea. Rubicon (i.e. pfSense) need this, and this is part of the diff-reduction effort.
64 HFSC classes isn't all that many if you want per-client queues.

For normal production the customer is able to set the values manually before compiling.

Yeah, but that's not ideal. If we want users to be able to tune this we should make it a tuneable rather than a compile-time value.

Happily the impact is very limited, because it really is only a tiny increase in memory use, and ALTQ is disabled by default anyway.
For HFSC it's literally ~2000 extra pointers, so as close to nothing as makes no difference. The CBQ structure is a bit bigger, but we're still talking about a few hundred kilobytes at most (for the extra ~1800 classes).

donner accepted this revision as: donner.Mar 3 2021, 7:19 PM

This revision is now accepted and ready to land.Mar 3 2021, 7:19 PM

Closed by commit rG448732b8e2d9: altq: Increase maximum number of CBQ and HFSC classes (authored by kp). · Explain WhyMar 4 2021, 7:58 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG448732b8e2d9: altq: Increase maximum number of CBQ and HFSC classes.

kp added a commit: rGbc98489262fb: altq: Increase maximum number of CBQ and HFSC classes.Mar 20 2021, 10:00 AM

kp added a commit: rG2e2e51f15ae5: altq: Increase maximum number of CBQ and HFSC classes.