Page MenuHomeFreeBSD

tests/sys/cddl: correctly quote atf_set "require.progs"
ClosedPublic

Authored by arichardson on Mar 4 2021, 6:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 12:48 AM
Unknown Object (File)
Sun, May 12, 11:19 AM
Unknown Object (File)
Tue, May 7, 2:10 PM
Unknown Object (File)
Wed, May 1, 9:42 PM
Unknown Object (File)
Thu, Apr 25, 9:23 PM
Unknown Object (File)
Sat, Apr 20, 11:34 AM
Unknown Object (File)
Apr 15 2024, 11:21 PM
Unknown Object (File)
Jan 2 2024, 1:45 PM
Subscribers

Details

Summary

The argument has to be a single whitespace-separate value. While touching
all these lines also add ksh93, since atf_set "require.progs" overrides
the default value specified in the Kyuafile. This then results in tests
being executed despite ksh93 not being installed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37583
Build 34472: arc lint + arc unit

Event Timeline

I didn't look at every file, but the overall pattern looks good. However, the fact that require.progs in a test file overrides the setting in the Kyua file, rather than adding to it, is arguably a bug. Maybe you should open a bug report upstream.

This revision is now accepted and ready to land.Mar 4 2021, 7:04 PM

I didn't look at every file, but the overall pattern looks good. However, the fact that require.progs in a test file overrides the setting in the Kyua file, rather than adding to it, is arguably a bug. Maybe you should open a bug report upstream.

Sounds good, I'll open an issue. Not sure if it's likely to be fixed though.