Page MenuHomeFreeBSD

tests/sys/cddl: correctly quote atf_set "require.progs"
ClosedPublic

Authored by arichardson on Mar 4 2021, 6:42 PM.

Details

Summary

The argument has to be a single whitespace-separate value. While touching
all these lines also add ksh93, since atf_set "require.progs" overrides
the default value specified in the Kyuafile. This then results in tests
being executed despite ksh93 not being installed.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I didn't look at every file, but the overall pattern looks good. However, the fact that require.progs in a test file overrides the setting in the Kyua file, rather than adding to it, is arguably a bug. Maybe you should open a bug report upstream.

This revision is now accepted and ready to land.Mar 4 2021, 7:04 PM

I didn't look at every file, but the overall pattern looks good. However, the fact that require.progs in a test file overrides the setting in the Kyua file, rather than adding to it, is arguably a bug. Maybe you should open a bug report upstream.

Sounds good, I'll open an issue. Not sure if it's likely to be fixed though.