Page MenuHomeFreeBSD
Differential D29049

link_elf_obj: Process init_array and fini_array
ClosedPublic
Actions

Authored by markj on Mar 3 2021, 9:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 12 2024, 7:40 PM
Unknown Object (File)
Dec 9 2024, 12:49 AM
Unknown Object (File)
Dec 6 2024, 3:46 PM
Unknown Object (File)
Nov 13 2024, 1:52 PM
Unknown Object (File)
Nov 10 2024, 3:48 PM
Unknown Object (File)
Oct 12 2024, 3:33 PM
Unknown Object (File)
Oct 9 2024, 9:45 AM
Unknown Object (File)
Oct 9 2024, 7:04 AM
View All 95 Files
Subscribers
imp

Details

Reviewers
kib
emaste
Commits
rGe37ad9ef372d: link_elf_obj: Handle init_array sections in KLDs
rG5e6989ba4f26: link_elf_obj: Handle init_array sections in KLDs
Summary

Reuse the existing logic for .ctors/.dtors.

This is required for KASAN.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37553
Build 34442: arc lint + arc unit

Event Timeline

markj created this revision.Mar 3 2021, 9:05 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 3 2021, 9:05 PM
markj requested review of this revision.Mar 3 2021, 9:05 PM
Harbormaster completed remote builds in B37550: Diff 85075.Mar 3 2021, 9:05 PM
markj added reviewers: kib, emaste.Mar 3 2021, 9:05 PM
markj added inline comments.
sys/kern/link_elf_obj.c
535

I am not sure why .dtors is not handled. I don't have a use for it but can implement it if it seems worthwhile.

kib added a comment.Mar 3 2021, 9:23 PM

In principle it could be that an object contains both .ctors and SHT_INIT_ARRAY sections. I suggest to warn, at least.

BTW, we rely on ld -r correctly merge all sections with the same name+attributes, but for many reasons this might not occur. So I think a warning is due if ctors_addr is non-NULL.

markj updated this revision to Diff 85080.Mar 3 2021, 9:59 PM

Print a warning if ctors_addr is already non-zero.

Harbormaster completed remote builds in B37553: Diff 85080.Mar 3 2021, 9:59 PM
kib accepted this revision.Mar 3 2021, 10:36 PM
This revision is now accepted and ready to land.Mar 3 2021, 10:36 PM
Closed by commit rG5e6989ba4f26: link_elf_obj: Handle init_array sections in KLDs (authored by markj). · Explain WhyMar 4 2021, 3:08 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG5e6989ba4f26: link_elf_obj: Handle init_array sections in KLDs.
markj added a commit: rGe37ad9ef372d: link_elf_obj: Handle init_array sections in KLDs.Mar 18 2021, 1:25 AM
khng mentioned this in D47383: libkldelf: skip loading zero-sized and non-SHF_ALLOC sections.Nov 12 2024, 7:56 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
43 lines

Diff 85080

View Options

sys/kern/link_elf_obj.c

Loading...