Page MenuHomeFreeBSD
Differential D28712

riscv: Don't set __NO_TLS to disable some uses of TLS.
ClosedPublic
Actions

Authored by jhb on Feb 16 2021, 6:52 PM.
Tags
None
Referenced Files
F170664418: D28712.id84030.diff
Sat, Sep 5, 9:52 PM
F170576104: D28712.id.diff
Sat, Sep 5, 11:47 AM
Unknown Object (File)
Fri, Sep 4, 10:50 PM
Unknown Object (File)
Fri, Sep 4, 9:07 AM
Unknown Object (File)
Thu, Sep 3, 6:55 PM
Unknown Object (File)
Wed, Sep 2, 1:39 PM
Unknown Object (File)
Wed, Sep 2, 8:05 AM
Unknown Object (File)
Wed, Sep 2, 7:19 AM
View All Files
Subscribers
imp

Details

Reviewers
mhorne
jrtc27
imp
Commits
rGdd176fd7e7b5: riscv: Don't set __NO_TLS to disable some uses of TLS.
Summary

TLS works fine on riscv.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Feb 16 2021, 6:52 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 16 2021, 6:52 PM
jhb requested review of this revision.Feb 16 2021, 6:52 PM
Harbormaster completed remote builds in B37063: Diff 84030.Feb 16 2021, 6:53 PM
jhb added a child revision: D28713: mips: Don't set __NO_TLS to disable some uses of TLS..Feb 16 2021, 6:53 PM
jhb added reviewers: mhorne, jrtc27.Feb 16 2021, 6:53 PM
jrtc27 added a comment.Feb 16 2021, 7:22 PM

MIPS should work fine too, and PowerPC64 ELFv1 really needs a comment saying why TLS is broken (and what it would take to remove this hack), though I'm unconvinced it is given that e.g. jemalloc doesn't die a horrible death.

mhorne accepted this revision.Feb 16 2021, 8:25 PM
This revision is now accepted and ready to land.Feb 16 2021, 8:25 PM
jhb added a comment.Feb 16 2021, 8:45 PM

MIPS is in another review as a child of this. I'll leave it to the ppc folks to look at that one: PowerPC.

imp accepted this revision.Feb 17 2021, 10:21 PM

Same comment I had on the mips review: why is this no longer needed? is a question that the commit message should answer, imho.

Closed by commit rGdd176fd7e7b5: riscv: Don't set __NO_TLS to disable some uses of TLS. (authored by jhb). · Explain WhyFeb 18 2021, 12:36 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGdd176fd7e7b5: riscv: Don't set __NO_TLS to disable some uses of TLS..

Revision Contents
Changeset List

PathSize
sys/
sys/
2 lines

Diff 84171

View Options

sys/sys/cdefs.h

Loading...