Page MenuHomeFreeBSD

riscv: Don't set __NO_TLS to disable some uses of TLS.

Authored by jhb on Feb 16 2021, 6:52 PM.


Diff Detail

R10 FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Feb 16 2021, 6:52 PM

MIPS should work fine too, and PowerPC64 ELFv1 really needs a comment saying why TLS is broken (and what it would take to remove this hack), though I'm unconvinced it is given that e.g. jemalloc doesn't die a horrible death.

This revision is now accepted and ready to land.Feb 16 2021, 8:25 PM

MIPS is in another review as a child of this. I'll leave it to the ppc folks to look at that one: PowerPC.

Same comment I had on the mips review: why is this no longer needed? is a question that the commit message should answer, imho.