I haven't seen the CSan warnings since applying this patch, before it would give me a warning anytime I read a file from smbfs.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 37107 Build 33996: arc lint + arc unit
Event Timeline
Comment Actions
This will cause a HUGE performance impact! sbspace() is called often and
twiddling the extra locks is not useful. You are just looking (reading) two
variables or even one variable in the sbused case. You do not need a lock for this!
Comment Actions
As you can see from the title of this diff I do not intend to merge this. It is just a debugging patch to find potentially racy accesses.
Comment Actions
update to latest WIP. This is purely for debugging, not intended to be merged (possibly with the exception of using atomic_load)