Following https://reviews.freebsd.org/D26075, (remove cuseeme reference in ipfirewall(4), give the handbook a similar treatment.
Details
Details
- Reviewers
emaste bcr 0mp debdrup - Commits
- R9:9ad75d64f7dd: [handbook] Remove reference to cusueeme
make install
Diff Detail
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 36927 Build 33816: arc lint + arc unit
Event Timeline
Comment Actions
Once these two minor things have been fixed (which can be done before commiting pushing), it looks good to me.
| documentation/content/en/books/handbook/firewalls/_index.adoc | ||
|---|---|---|
| 1286 | You need a bit of wordsmithing here to improve readability, and then there's a nit about the path to /etc/rc.conf which brings it in line with the rest of the documentation. | |
| documentation/content/en/books/handbook/firewalls/_index.adoc | ||
|---|---|---|
| 1286 | Hi Daniel, do you want to me completely rewrite the paragraph, or use enters at sentence stops? I'm not 100% sure what you would like. | |
Comment Actions
It's possible Phabricator mangled things.
What I wanted you to do was:
1: Change 'seem' to 'appear'
2: Put the full path to /etc/rc.conf (instead of just rc.conf).
Comment Actions
I can just fold that change in, and we can follow up with a more extensive rewrite later on perhaps.
Comment Actions
Ah yes, now that you mention it explicitly the improvements are applied in your comment.
I didn't notice at first as the whole paragraph was highlighted... my bad.
I don't have a bit so someone could fold those in for me :-), thanks for that @emaste