Page MenuHomeFreeBSD
Differential D26075

ipfirewall(4): Mention Cuseeme support was removed from libalias
ClosedPublic
Actions

Authored by driesm on Aug 15 2020, 7:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 7:59 AM
Unknown Object (File)
Thu, Jan 16, 11:59 PM
Unknown Object (File)
Dec 25 2024, 7:58 AM
Unknown Object (File)
Dec 20 2024, 9:59 AM
Unknown Object (File)
Dec 9 2024, 2:27 PM
Unknown Object (File)
Dec 4 2024, 5:38 AM
Unknown Object (File)
Nov 28 2024, 10:08 PM
Unknown Object (File)
Nov 26 2024, 11:06 AM
View All Files
Subscribers
imp
markj

Details

Reviewers
bcr
emaste
Group Reviewers
manpages
Commits
rS364404: ipfirewall(4): remove Cuseeme from supported list
Summary

Cuseeme support was removed from libalias in FreeBSD 13:
https://reviews.freebsd.org/D24790

Test Plan

mandoc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

driesm requested review of this revision.Aug 15 2020, 7:44 AM
driesm updated this revision to Diff 75845.
driesm created this revision.

Also remove cuseeme reference in the man page itself.

driesm retitled this revision from Mention Cuseeme support was removed from libalias to ipfirewall(4): Mention Cuseeme support was removed from libalias.Aug 18 2020, 10:13 AM
emaste accepted this revision.Aug 19 2020, 5:33 PM
emaste added a subscriber: markj.
emaste added inline comments.
share/man/man4/ipfirewall.4
136–137 ↗(On Diff #75845)

We should check if any of these others have been removed already, and also remove any other obsolete ones.

163–167 ↗(On Diff #75845)

I think this part is fine but not sure it's really necessary.

This revision is now accepted and ready to land.Aug 19 2020, 5:33 PM
markj added inline comments.Aug 19 2020, 5:40 PM
share/man/man4/ipfirewall.4
163–167 ↗(On Diff #75845)

The removal will be mentioned in 13.0 release notes, I don't think noting it in a man page is standard. I would just drop this hunk.

driesm updated this revision to Diff 75996.Aug 19 2020, 5:46 PM

Ah yes it makes perfect sense to not document removal of code in man pages. That would result in some big ones :-). Thanks!

This revision now requires review to proceed.Aug 19 2020, 5:46 PM
driesm marked 2 inline comments as done.Aug 19 2020, 5:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2020, 5:52 PM
Closed by commit rS364404: ipfirewall(4): remove Cuseeme from supported list (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rS364404: ipfirewall(4): remove Cuseeme from supported list.
Herald added a reviewer: manpages. · View Herald TranscriptAug 19 2020, 5:52 PM
Herald added a subscriber: imp. · View Herald Transcript
driesm mentioned this in D26123: [handbook] Remove reference to cusueeme.Aug 19 2020, 5:53 PM
emaste mentioned this in R9:9ad75d64f7dd: [handbook] Remove reference to cusueeme.Feb 24 2021, 6:57 PM

Revision Contents
Changeset List

PathSize
head/
share/
man/
man4/
4 lines

Diff 76002

View Options

head/share/man/man4/ipfirewall.4

Loading...