Differential D26075

ipfirewall(4): Mention Cuseeme support was removed from libalias
ClosedPublic
Actions

Authored by driesm on Aug 15 2020, 7:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 12, 1:51 AM

	Unknown Object (File)
	Tue, Apr 9, 8:15 PM

	Unknown Object (File)
	Sun, Mar 31, 1:36 PM

	Unknown Object (File)
	Mar 9 2024, 11:40 AM

	Unknown Object (File)
	Feb 11 2024, 4:33 PM

	Unknown Object (File)
	Feb 10 2024, 5:14 PM

	Unknown Object (File)
	Jan 14 2024, 4:01 PM

	Unknown Object (File)
	Dec 26 2023, 9:26 AM

View All 49 Files

Subscribers

Details

Reviewers

bcr
emaste

Group Reviewers

Commits

rS364404: ipfirewall(4): remove Cuseeme from supported list

Summary

Cuseeme support was removed from libalias in FreeBSD 13:
https://reviews.freebsd.org/D24790

Test Plan

mandoc

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Also remove cuseeme reference in the man page itself.

driesm retitled this revision from Mention Cuseeme support was removed from libalias to ipfirewall(4): Mention Cuseeme support was removed from libalias.Aug 18 2020, 10:13 AM

emaste accepted this revision.Aug 19 2020, 5:33 PM

emaste added a subscriber: markj.

emaste added inline comments.

share/man/man4/ipfirewall.4
136–137	We should check if any of these others have been removed already, and also remove any other obsolete ones.
163–167	I think this part is fine but not sure it's really necessary.

This revision is now accepted and ready to land.Aug 19 2020, 5:33 PM

markj added inline comments.Aug 19 2020, 5:40 PM

share/man/man4/ipfirewall.4
163–167	The removal will be mentioned in 13.0 release notes, I don't think noting it in a man page is standard. I would just drop this hunk.

Ah yes it makes perfect sense to not document removal of code in man pages. That would result in some big ones :-). Thanks!

This revision now requires review to proceed.Aug 19 2020, 5:46 PM

driesm marked 2 inline comments as done.Aug 19 2020, 5:46 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2020, 5:52 PM

Closed by commit rS364404: ipfirewall(4): remove Cuseeme from supported list (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS364404: ipfirewall(4): remove Cuseeme from supported list.

Herald added a reviewer: manpages. · View Herald TranscriptAug 19 2020, 5:52 PM

Herald added a subscriber: imp. · View Herald Transcript

driesm mentioned this in D26123: [handbook] Remove reference to cusueeme.Aug 19 2020, 5:53 PM

emaste mentioned this in R9:9ad75d64f7dd: [handbook] Remove reference to cusueeme.Feb 24 2021, 6:57 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

2 lines

Diff 75996

share/man/man4/ipfirewall.4

Loading...