elfctl: allow features to be specified by value
ClosedPublic
Actions

Authored by emaste on Jan 22 2021, 5:25 PM.

Details

Reviewers

kib
markj

Commits

rGf2b5999b2166: elfctl: allow features to be specified by value
rGd7e23b5cdd84: elfctl: allow features to be specified by value
rG86f33b5fcf60: elfctl: allow features to be specified by value

Summary

This will allow elfctl on older releases to set bits that are not yet known there, so that the binary will have the correct settings applied if run on a later FreeBSD version.

Suggested by: kib
Sponsored by: The FreeBSD Foundation

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jan 22 2021, 5:25 PM

emaste created this revision.

LGTM from manpages

kib added inline comments.Jan 22 2021, 6:53 PM

usr.bin/elfctl/elfctl.c
264	Do you want to check that only single bit is set in the val?

emaste added inline comments.Jan 22 2021, 6:55 PM

usr.bin/elfctl/elfctl.c
264	I didn't do that semi-intentionally, so that you could use e.g. `elfctl -e =0x81`.

Add example of combining numerical values to man page

kib accepted this revision.Jan 22 2021, 7:25 PM

This revision is now accepted and ready to land.Jan 22 2021, 7:25 PM

Closed by commit rG86f33b5fcf60: elfctl: allow features to be specified by value (authored by emaste). · Explain WhyJan 22 2021, 7:41 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG86f33b5fcf60: elfctl: allow features to be specified by value.

emaste added a commit: rGd7e23b5cdd84: elfctl: allow features to be specified by value.Jan 26 2021, 2:48 PM

emaste added a commit: rGf2b5999b2166: elfctl: allow features to be specified by value.Jan 27 2021, 12:26 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

elfctl/

elfctl.1

15 lines

elfctl.c

25 lines

Diff 82733

View Options

usr.bin/elfctl/elfctl.1