Require uint32_t alignment for ipfw_insn
ClosedPublic
Actions

Authored by arichardson on Jan 1 2021, 1:41 PM.

Details

Reviewers

ae
melifaro
glebius

Commits

rGa81c165bce14: Require uint32_t alignment for ipfw_insn

Summary

There are many casts of this struct to uint32_t, so we also need to ensure
that it is sufficiently aligned to safely perform this cast on architectures
that don't allow unaligned accesses. This fixes lots of -Wcast-align warnings.

Test Plan

fixes lots of compiler warnings

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Jan 1 2021, 1:41 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 1 2021, 1:41 PM

arichardson requested review of this revision.Jan 1 2021, 1:41 PM

Harbormaster completed remote builds in B35838: Diff 81469.Jan 1 2021, 1:41 PM

arichardson added inline comments.Jan 1 2021, 1:43 PM

sys/netinet/ip_fw.h
342	This could be _Alignas(uint32_t) with C11, but if we fall back to attribute((aligned)), we need an integer and can't use a type name.

ping?

ae accepted this revision.Jan 19 2021, 10:24 AM

This revision is now accepted and ready to land.Jan 19 2021, 10:24 AM

I have some doubts, that this change is safe. But probably we will see the result quickly.

Closed by commit rGa81c165bce14: Require uint32_t alignment for ipfw_insn (authored by arichardson). · Explain WhyJan 19 2021, 9:38 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rGa81c165bce14: Require uint32_t alignment for ipfw_insn.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_fw.h

2 lines

Diff 82588

View Options

Require uint32_t alignment for ipfw_insnClosedPublicActions