Page MenuHomeFreeBSD
Differential D3505

Prefix UDP local function with a udp_ prefix to avoid confusion
ClosedPublic
Actions

Authored by bz on Aug 27 2015, 2:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 11:34 AM
Unknown Object (File)
Wed, Apr 24, 10:15 AM
Unknown Object (File)
Jan 9 2024, 8:16 PM
Unknown Object (File)
Jan 9 2024, 8:16 PM
Unknown Object (File)
Jan 9 2024, 8:16 PM
Unknown Object (File)
Jan 9 2024, 8:02 PM
Unknown Object (File)
Jan 8 2024, 7:25 PM
Unknown Object (File)
Dec 31 2023, 2:06 AM
View All 91 Files
Subscribers
imp

Details

Reviewers
gnn
rwatson
Commits
rS287211: get_inpcbinfo() and get_pcblist() are UDP local functions and
Summary

get_inpcbinfo() and get_pcblist() are UDP local functions and
do not do what one would expect by name. Prefix them with "udp_"
to at least obviously limit the scope.

Test Plan

builds.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 258
Build 258: arc lint + arc unit

Event Timeline

bz updated this revision to Diff 8257.Aug 27 2015, 2:01 PM
bz retitled this revision from to Prefix UDP local function with a udp_ prefix to avoid confusion.
bz updated this object.
bz edited the test plan for this revision. (Show Details)
bz added reviewers: rwatson, gnn.
Herald added a subscriber: imp. · View Herald TranscriptAug 27 2015, 2:01 PM
rwatson accepted this revision.Aug 27 2015, 2:19 PM
rwatson edited edge metadata.

Although I have read through it and believe that the principle of this patch is a very good one, I have not, myself, tested it.

This revision is now accepted and ready to land.Aug 27 2015, 2:19 PM
gnn accepted this revision.Aug 27 2015, 2:41 PM
gnn edited edge metadata.

This is a purely textual change. Go for it.

Closed by commit rS287211: get_inpcbinfo() and get_pcblist() are UDP local functions and (authored by bz). · Explain WhyAug 27 2015, 3:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
netinet/
20 lines
4 lines
netinet6/
20 lines

Diff 8257

View Options

sys/netinet/udp_usrreq.c

Loading...
View Options

sys/netinet/udp_var.h

Loading...
View Options

sys/netinet6/udp6_usrreq.c

Loading...