Remove unnecessary locks in function timerfd_close
ClosedPublic
Actions

Authored by ankohuu_outlook.com on Jan 14 2021, 4:52 AM.

Details

Reviewers

dchagin
delphij

Commits

rGa95b05950a2f: linux: remove locks around callout_drain in timerfd_close()
rG14c40d2c292d: linux: remove locks around callout_drain in timerfd_close()

Summary

The Lock around timerfd_drain is unnecessary and may cause
deadloop when close timerfd during timer execution

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36190
Build 33079: arc lint + arc unit

Event Timeline

ankohuu_outlook.com created this revision.Jan 14 2021, 4:52 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJan 14 2021, 4:52 AM

ankohuu_outlook.com requested review of this revision.Jan 14 2021, 4:52 AM

Harbormaster completed remote builds in B36190: Diff 82247.Jan 14 2021, 4:52 AM

lwhsu added a reviewer: dchagin.Jan 14 2021, 6:11 AM

ygy added a subscriber: ygy.Jan 14 2021, 6:27 AM

LGTM

This revision is now accepted and ready to land.Jan 14 2021, 8:22 AM

ankohuu_outlook.com mentioned this in D28231: linux_timerfd_settime set expirations count to zero.Feb 2 2021, 3:11 PM

Closed by commit rG14c40d2c292d: linux: remove locks around callout_drain in timerfd_close() (authored by ankohuu_outlook.com, committed by trasz). · Explain WhyFeb 3 2021, 7:48 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rG14c40d2c292d: linux: remove locks around callout_drain in timerfd_close().

trasz added a commit: rGa95b05950a2f: linux: remove locks around callout_drain in timerfd_close().Feb 17 2022, 1:46 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_event.c

2 lines

Diff 82247

View Options

sys/compat/linux/linux_event.c

Remove unnecessary locks in function timerfd_closeClosedPublicActions