Details

Reviewers

Group Reviewers

Commits

rG3de9c792eebe: netgraph/ng_bridge: Make simple internal functions read-only
rG1e2c1b762275: netgraph/ng_bridge: Make simple internal functions read-only
rG6117aa58fa4f: netgraph/ng_bridge: Make simple internal functions read-only
rGbb67e52db143: netgraph/ng_bridge: Make simple internal functions read-only

Summary

Switch very simple internal functions to explicit handle const data.

Depends on D28123

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36179
Build 33068: arc lint + arc unit

Event Timeline

donner created this revision.Jan 13 2021, 8:22 PM

Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptJan 13 2021, 8:22 PM

donner requested review of this revision.Jan 13 2021, 8:22 PM

Harbormaster completed remote builds in B36178: Diff 82226.Jan 13 2021, 8:22 PM

donner added a reviewer: network.Jan 13 2021, 8:22 PM

revert the idea of specialized "const pointers"

Harbormaster completed remote builds in B36179: Diff 82227.Jan 13 2021, 8:45 PM

It's far that simple. I missed the difference between

const node_p: a constant pointer to a modifiable node.
struct ng_node const * : a modifiable pointer to a constant node.

Because I need immutable data structures, the latter is required.
But those structures and helper functions are defined in the central netgraph.h and ng_base.c.
Hence I have to annotate the base system with const, and also every helper function, which does not modify the data.

I think it's worth the effort, because it will ease the way write multithreaded netgraph modules and fix several still hidden race conditions.