ioat(4): Minor style cleanups
ClosedPublic
Actions

Authored by cem on Aug 25 2015, 4:33 PM.

Details

Reviewers

markj
jimharris
ngie

Commits

rS287138: ioat(4): Minor style cleanups

Summary

Suggested-by: Ngie

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 234
Build 234: arc lint + arc unit

Event Timeline

cem updated this revision to Diff 8204.Aug 25 2015, 4:33 PM

cem retitled this revision from to ioat(4): Minor style cleanups.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added reviewers: jimharris, markj, ngie.

Herald added a subscriber: imp. · View Herald TranscriptAug 25 2015, 4:33 PM

jimharris accepted this revision.Aug 25 2015, 4:59 PM

jimharris edited edge metadata.

jimharris added inline comments.

sys/dev/ioat/ioat_test.c
120 ↗	(On Diff #8204)	I still think "miscompare" is the better term here. It is a very commonly understood and often used term when testing for data integrity. But it's not worth debating any further.

This revision is now accepted and ready to land.Aug 25 2015, 4:59 PM

cem added inline comments.Aug 25 2015, 5:04 PM

sys/dev/ioat/ioat_test.c
120 ↗	(On Diff #8204)	I hadn't heard of it. I'm ok leaving it as-is if it's a common term in the context.

Drop miscompare -> mismatch.

This revision now requires review to proceed.Aug 25 2015, 5:33 PM

markj accepted this revision.Aug 25 2015, 5:35 PM

markj edited edge metadata.

This revision is now accepted and ready to land.Aug 25 2015, 5:35 PM

jimharris accepted this revision.Aug 25 2015, 5:36 PM

jimharris edited edge metadata.

Closed by commit rS287138: ioat(4): Minor style cleanups (authored by cem). · Explain WhyAug 25 2015, 5:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ioat/

ioat.c

2 lines

tools/

ioat/

Makefile

1 line

Diff 8206

View Options

sys/dev/ioat/ioat.c