Page MenuHomeFreeBSD
Differential D3481

ioat(4): Minor style cleanups
ClosedPublic
Actions

Authored by cem on Aug 25 2015, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 4, 4:37 PM
Unknown Object (File)
Sat, Nov 29, 11:49 AM
Unknown Object (File)
Mon, Nov 24, 1:55 PM
Unknown Object (File)
Sun, Nov 23, 7:33 PM
Unknown Object (File)
Fri, Nov 21, 1:50 PM
Unknown Object (File)
Thu, Nov 20, 7:28 AM
Unknown Object (File)
Nov 9 2025, 8:00 PM
Unknown Object (File)
Oct 26 2025, 11:19 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
jimharris
ngie
Commits
rS287138: ioat(4): Minor style cleanups
Summary

Suggested-by: Ngie

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 233
Build 233: arc lint + arc unit

Event Timeline

cem updated this revision to Diff 8204.Aug 25 2015, 4:33 PM
cem retitled this revision from to ioat(4): Minor style cleanups.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: jimharris, markj, ngie.
Herald added a subscriber: imp. · View Herald TranscriptAug 25 2015, 4:33 PM
jimharris accepted this revision.Aug 25 2015, 4:59 PM
jimharris edited edge metadata.
jimharris added inline comments.
sys/dev/ioat/ioat_test.c
120

I still think "miscompare" is the better term here. It is a very commonly understood and often used term when testing for data integrity. But it's not worth debating any further.

This revision is now accepted and ready to land.Aug 25 2015, 4:59 PM
cem added inline comments.Aug 25 2015, 5:04 PM
sys/dev/ioat/ioat_test.c
120

I hadn't heard of it. I'm ok leaving it as-is if it's a common term in the context.

cem updated this revision to Diff 8206.Aug 25 2015, 5:33 PM
cem edited edge metadata.

Drop miscompare -> mismatch.

This revision now requires review to proceed.Aug 25 2015, 5:33 PM
markj accepted this revision.Aug 25 2015, 5:35 PM
markj edited edge metadata.
This revision is now accepted and ready to land.Aug 25 2015, 5:35 PM
jimharris accepted this revision.Aug 25 2015, 5:36 PM
jimharris edited edge metadata.
Closed by commit rS287138: ioat(4): Minor style cleanups (authored by cem). · Explain WhyAug 25 2015, 5:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
ioat/
2 lines
2 lines
tools/
tools/
ioat/
1 line

Diff 8204

View Options

sys/dev/ioat/ioat.c

Loading...
View Options

sys/dev/ioat/ioat_test.c

Loading...
View Options

tools/tools/ioat/Makefile

Loading...