brise has been deprecated since 2019.
This revision replaces the usage of chinese/brise in fcitx-rime withRimeData-based schemas.
RimeData-based schemas live in ${LOCALBASE}/share/rime-data.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 35444 Build 32354: arc lint + arc unit
Event Timeline
Comment Actions
- Deprecate chinese/brise in favor of chinese/rime-data
Updating D27630: Upgrade fcitx-rime to use rime-data.
Add chinese/rime-cantonese.
Comment Actions
I can add chinese/rime-cantonese and chinese/rime-data soon, but please file a ticket in bugzilla to ask approval from the maintainer of chinese/fcitx-rime regarding the changes to it. BTW, we need to bump its PORTREVISION.
In short, let's do this in two steps, adding the dependency first, then modify chinese/fcitx-rime to use them.
Comment Actions
Oh, and we probably want to mark chinese/brise as DEPRECATED first, but if there is no ports depend on it, of course we can do it faster. I suggest making this as the third step.
| chinese/fcitx-rime/Makefile | ||
|---|---|---|
| 5–6 | PORTREVISION bump needed. | |
| chinese/rime-data/pkg-descr | ||
|---|---|---|
| 4 | It seems we retrieve data from multiple rime repositories, why do we use rime-bopomofo here? BTW, does it make more sense to create fine-grained ports like data-bopomofo and so on? | |
Comment Actions
And since there is a maintainer, we also want to inform them, or wait a little longer after the maintainer timeout. Yes, this needs a ticket in bugzilla.
| chinese/rime-data/pkg-descr | ||
|---|---|---|
| 4 | My original attempt was to create a fine-grained ports such as rime-bopomofo. However the attempt doesn't work well so far as including all these fine-grained data files in a rime-data metaport seems to confuse the infrastructure on dependency resolving. Generally to make sure the user experience isn't affected a basic set of schemas has to be included. | |
| chinese/fcitx-rime/Makefile | ||
|---|---|---|
| 4–5 | Should be distversion | |
| 8 | Redirects to https | |
| 19–20 | Looks like a copy paste issue, should be BUILD_DEPENDS= bash:shells/bash \ | |
Comment Actions
More ports are split from chinese/rime-data
- New port: chinese/rime-prelude
- New port: chinese/rime-essay
- New port: chinese/rime-cantonese
- New port: chinese/rime-terra-pinyin
- New port: chinese/rime-luna-pinyin
- New port: chinese/rime-bopomofo
- New port: chinese/rime-cangjie
- New port: chinese/rime-stroke
- New port: chinese/rime-data
- Update fcitx-rime to use RimeData instead of brise
- chinese/fcitx-rime depends on chinese/rime-data
- chinese/fcitx-rime: Address diizzy's comments on Makefile
Comment Actions
Rebased to D27652:
- Update fcitx-rime to use RimeData instead of brise
- chinese/fcitx-rime depends on chinese/rime-data
- chinese/fcitx-rime: Address diizzy's comments on Makefile
Comment Actions
Rebased.
- chinese/rime-*: Use CP instead of RLN for data files from localbase
- Update chinese/fcitx-rime to use RimeData instead
Comment Actions
Rebased.
- Update fcitx-rime to use RimeData instead of brise
- chinese/fcitx-rime depends on chinese/rime-data
- chinese/fcitx-rime: Address diizzy's comments on Makefile
- chinese/fcitx-rime: Depends on individual essential schema ports
Comment Actions
LGTM.
Since the maintainer has been reset and diff updated, we can get this committed soon. ;)