Page MenuHomeFreeBSD
Differential D27716

chinese/rime-*: Use CP instead of RLN for data files from localbase
ClosedPublic
Actions

Authored by khng on Dec 22 2020, 6:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 4:17 PM
Unknown Object (File)
Fri, Apr 19, 4:17 PM
Unknown Object (File)
Fri, Apr 19, 4:17 PM
Unknown Object (File)
Fri, Apr 19, 4:17 PM
Unknown Object (File)
Fri, Apr 19, 4:17 PM
Unknown Object (File)
Fri, Apr 19, 4:17 PM
Unknown Object (File)
Fri, Apr 19, 4:17 PM
Unknown Object (File)
Fri, Apr 19, 4:17 PM
View All Files
Subscribers
mat

Details

Reviewers
lwhsu
ygy
Commits
rP559588: chinese/rime-*: Use CP instead of RLN for data files from localbase
Summary

For data files from localbase (in ${LOCALBASE}/share/rime-data),
copy them to the build directory instead of symbolically linking
them.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng created this revision.Dec 22 2020, 6:49 AM
Herald added a subscriber: mat. · View Herald TranscriptDec 22 2020, 6:49 AM
khng requested review of this revision.Dec 22 2020, 6:49 AM
Harbormaster completed remote builds in B35591: Diff 81030.Dec 22 2020, 6:49 AM
khng updated this revision to Diff 81031.Dec 22 2020, 6:52 AM

Remove the accidentally added changes

Harbormaster completed remote builds in B35592: Diff 81031.Dec 22 2020, 6:52 AM
khng updated this revision to Diff 81032.Dec 22 2020, 6:55 AM

Rebased.

  • Update chinese/fcitx-rime to use RimeData instead
Harbormaster completed remote builds in B35593: Diff 81032.Dec 22 2020, 6:55 AM
khng updated this revision to Diff 81033.Dec 22 2020, 6:56 AM

Reverted diff #81032

Harbormaster completed remote builds in B35594: Diff 81033.Dec 22 2020, 6:56 AM
khng added a child revision: D27630: Upgrade chinese/fcitx-rime to use RimeData-based schemas..Dec 22 2020, 7:06 AM
lwhsu added a comment.Dec 22 2020, 7:31 AM

How about using ${INSTALL_DATA} ?

khng retitled this revision from chinese/rime-*: Use CP instead of RLN for data files from localbase to chinese/rime-*: Use INSTALL_DATA instead of RLN for data files from localbase.Dec 22 2020, 7:37 AM
khng updated this revision to Diff 81037.Dec 22 2020, 7:40 AM

Updated

Harbormaster completed remote builds in B35598: Diff 81037.Dec 22 2020, 7:40 AM
khng updated this revision to Diff 81039.Dec 22 2020, 7:46 AM

Reverted the most recent INSTALL_DATA changes

Harbormaster completed remote builds in B35600: Diff 81039.Dec 22 2020, 7:46 AM
khng retitled this revision from chinese/rime-*: Use INSTALL_DATA instead of RLN for data files from localbase to chinese/rime-*: Use CP instead of RLN for data files from localbase.Dec 22 2020, 7:46 AM
In D27716#619538, @lwhsu wrote:

How about using ${INSTALL_DATA} ?

CP install seems to be fine for do-build

ygy accepted this revision.Dec 28 2020, 10:38 AM
This revision is now accepted and ready to land.Dec 28 2020, 10:38 AM
Closed by commit rP559588: chinese/rime-*: Use CP instead of RLN for data files from localbase (authored by ygy). · Explain WhyDec 29 2020, 3:30 PM
This revision was automatically updated to reflect the committed changes.
ygy added a commit: rP559588: chinese/rime-*: Use CP instead of RLN for data files from localbase.

Revision Contents
Changeset List

PathSize
head/
chinese/
rime-bopomofo/
3 lines
rime-cangjie/
3 lines
rime-cantonese/
3 lines
rime-luna-pinyin/
3 lines
rime-stroke/
3 lines
rime-terra-pinyin/
3 lines

Diff 81301

View Options

head/chinese/rime-bopomofo/Makefile

Loading...
View Options

head/chinese/rime-cangjie/Makefile

Loading...
View Options

head/chinese/rime-cantonese/Makefile

Loading...
View Options

head/chinese/rime-luna-pinyin/Makefile

Loading...
View Options

head/chinese/rime-stroke/Makefile

Loading...
View Options

head/chinese/rime-terra-pinyin/Makefile

Loading...