Page MenuHomeFreeBSD
Differential D27564

posixshm_test.c: tautology in test
ClosedPublic
Actions

Authored by rlibby on Dec 10 2020, 10:43 PM.
Tags
None
Referenced Files
F101739086: D27564.diff
Sun, Nov 3, 2:05 AM
Unknown Object (File)
Tue, Oct 22, 5:48 AM
Unknown Object (File)
Sun, Oct 20, 7:40 PM
Unknown Object (File)
Sun, Oct 6, 9:03 PM
Unknown Object (File)
Oct 3 2024, 10:05 PM
Unknown Object (File)
Oct 1 2024, 7:25 PM
Unknown Object (File)
Sep 29 2024, 6:35 AM
Unknown Object (File)
Sep 24 2024, 9:54 PM
View All 52 Files
Subscribers
imp
kib

Details

Reviewers
markj
kib
Commits
rS368570: posixshm_test.c: remove tautological checks
Summary

gcc -Wtype-limits complained about unsigned >= 0. Cast to signed so
that it might check for underflow.

Alternately, we might just delete the checks.

Test Plan
env MAKEOBJDIRPREFIX=/usr/obj/gcc6 CROSS_TOOLCHAIN=amd64-gcc make buildworld
env MAKEOBJDIRPREFIX=/usr/obj/clang make buildworld

... I'll look into actually running this test too.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35334
Build 32263: arc lint + arc unit

Event Timeline

rlibby created this revision.Dec 10 2020, 10:43 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 10 2020, 10:43 PM
rlibby requested review of this revision.Dec 10 2020, 10:43 PM
Harbormaster completed remote builds in B35331: Diff 80565.Dec 10 2020, 10:43 PM
kib added a comment.Dec 10 2020, 11:24 PM

The in-kernel source for the sysctl is also unsigned.
I think that the checks can be safely dropped.

markj added a comment.Dec 10 2020, 11:28 PM
In D27564#615982, @kib wrote:

The in-kernel source for the sysctl is also unsigned.
I think that the checks can be safely dropped.

I agree. I can't remember why I added the checks.

rlibby updated this revision to Diff 80568.Dec 11 2020, 12:42 AM

feedback: just remove the checks

Harbormaster completed remote builds in B35334: Diff 80568.Dec 11 2020, 12:42 AM
markj accepted this revision.Dec 11 2020, 12:43 AM
This revision is now accepted and ready to land.Dec 11 2020, 12:43 AM
kib accepted this revision.Dec 11 2020, 4:32 AM
Closed by commit rS368570: posixshm_test.c: remove tautological checks (authored by rlibby). · Explain WhyDec 11 2020, 10:53 PM
This revision was automatically updated to reflect the committed changes.
rlibby added a commit: rS368570: posixshm_test.c: remove tautological checks.

Revision Contents
Changeset List

PathSize
tests/
sys/
posixshm/
2 lines

Diff 80568

View Options

tests/sys/posixshm/posixshm_test.c

Loading...