Page MenuHomeFreeBSD

posixshm_test.c: tautology in test
ClosedPublic

Authored by rlibby on Dec 10 2020, 10:43 PM.
Tags
None
Referenced Files
F92968485: D27564.id80568.diff
Thu, Sep 5, 7:33 PM
Unknown Object (File)
Thu, Sep 5, 8:35 AM
Unknown Object (File)
Mon, Sep 2, 11:02 PM
Unknown Object (File)
Sat, Aug 31, 11:17 AM
Unknown Object (File)
Jul 9 2024, 6:58 PM
Unknown Object (File)
Apr 13 2024, 8:58 PM
Unknown Object (File)
Apr 12 2024, 2:15 PM
Unknown Object (File)
Apr 12 2024, 1:53 PM
Subscribers

Details

Summary

gcc -Wtype-limits complained about unsigned >= 0. Cast to signed so
that it might check for underflow.


Alternately, we might just delete the checks.

Test Plan
env MAKEOBJDIRPREFIX=/usr/obj/gcc6 CROSS_TOOLCHAIN=amd64-gcc make buildworld
env MAKEOBJDIRPREFIX=/usr/obj/clang make buildworld

... I'll look into actually running this test too.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The in-kernel source for the sysctl is also unsigned.
I think that the checks can be safely dropped.

In D27564#615982, @kib wrote:

The in-kernel source for the sysctl is also unsigned.
I think that the checks can be safely dropped.

I agree. I can't remember why I added the checks.

feedback: just remove the checks

This revision is now accepted and ready to land.Dec 11 2020, 12:43 AM
This revision was automatically updated to reflect the committed changes.