Page MenuHomeFreeBSD

posixshm_test.c: tautology in test
ClosedPublic

Authored by rlibby on Dec 10 2020, 10:43 PM.
Tags
None
Referenced Files
F163433085: D27564.id.diff
Thu, Jul 23, 4:10 AM
Unknown Object (File)
Thu, Jul 2, 11:58 AM
Unknown Object (File)
May 21 2026, 1:47 AM
Unknown Object (File)
May 21 2026, 1:47 AM
Unknown Object (File)
Apr 30 2026, 9:05 AM
Unknown Object (File)
Apr 28 2026, 11:37 AM
Unknown Object (File)
Apr 19 2026, 6:45 PM
Unknown Object (File)
Apr 12 2026, 12:24 PM
Subscribers

Details

Summary

gcc -Wtype-limits complained about unsigned >= 0. Cast to signed so
that it might check for underflow.


Alternately, we might just delete the checks.

Test Plan
env MAKEOBJDIRPREFIX=/usr/obj/gcc6 CROSS_TOOLCHAIN=amd64-gcc make buildworld
env MAKEOBJDIRPREFIX=/usr/obj/clang make buildworld

... I'll look into actually running this test too.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The in-kernel source for the sysctl is also unsigned.
I think that the checks can be safely dropped.

In D27564#615982, @kib wrote:

The in-kernel source for the sysctl is also unsigned.
I think that the checks can be safely dropped.

I agree. I can't remember why I added the checks.

feedback: just remove the checks

This revision is now accepted and ready to land.Dec 11 2020, 12:43 AM
This revision was automatically updated to reflect the committed changes.