Page MenuHomeFreeBSD

posixshm_test.c: tautology in test
ClosedPublic

Authored by rlibby on Dec 10 2020, 10:43 PM.
Tags
None
Referenced Files
F133602808: D27564.id80568.diff
Sun, Oct 26, 11:22 PM
Unknown Object (File)
Sun, Oct 19, 1:34 AM
Unknown Object (File)
Fri, Oct 17, 8:35 AM
Unknown Object (File)
Thu, Oct 16, 10:51 PM
Unknown Object (File)
Thu, Oct 16, 10:51 PM
Unknown Object (File)
Thu, Oct 16, 10:50 PM
Unknown Object (File)
Thu, Oct 16, 2:06 PM
Unknown Object (File)
Tue, Oct 14, 12:11 AM
Subscribers

Details

Summary

gcc -Wtype-limits complained about unsigned >= 0. Cast to signed so
that it might check for underflow.


Alternately, we might just delete the checks.

Test Plan
env MAKEOBJDIRPREFIX=/usr/obj/gcc6 CROSS_TOOLCHAIN=amd64-gcc make buildworld
env MAKEOBJDIRPREFIX=/usr/obj/clang make buildworld

... I'll look into actually running this test too.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The in-kernel source for the sysctl is also unsigned.
I think that the checks can be safely dropped.

In D27564#615982, @kib wrote:

The in-kernel source for the sysctl is also unsigned.
I think that the checks can be safely dropped.

I agree. I can't remember why I added the checks.

feedback: just remove the checks

This revision is now accepted and ready to land.Dec 11 2020, 12:43 AM
This revision was automatically updated to reflect the committed changes.