Handle return from KDB_WHY_TRAP on arm and mips
ClosedPublic
Actions

Authored by mhorne on Dec 10 2020, 3:09 PM.

Details

Reviewers

jhb
avg

Commits

rG65d1a4cfda73: Handle KDB_WHY_TRAP return on arm and mips

Summary

Upon exit from the debugger, checking the return code of kdb_trap()
allows one to retry the fatal page fault. This matches what is done on
all other architectures.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35297
Build 32230: arc lint + arc unit

Event Timeline

mhorne created this revision.Dec 10 2020, 3:09 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptDec 10 2020, 3:09 PM

mhorne requested review of this revision.Dec 10 2020, 3:09 PM

Harbormaster completed remote builds in B35297: Diff 80518.Dec 10 2020, 3:09 PM

It's been a while since I touched that kind of code, but I think that this change is good.

jhb accepted this revision.Dec 10 2020, 9:08 PM

This revision is now accepted and ready to land.Dec 10 2020, 9:08 PM

mhorne mentioned this in D27534: riscv: handle debug.debugger_on_trap for fatal page faults.Dec 10 2020, 9:12 PM

Closed by commit rG65d1a4cfda73: Handle KDB_WHY_TRAP return on arm and mips (authored by mhorne). · Explain WhyJan 2 2021, 11:07 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG65d1a4cfda73: Handle KDB_WHY_TRAP return on arm and mips.

Revision Contents
Changeset List

Path

Size

sys/

arm/

trap-v6.c

7 lines

mips/

trap.c

7 lines

Diff 80518

View Options

sys/arm/arm/trap-v6.c