riscv: handle debug.debugger_on_trap for fatal page faults
ClosedPublic
Actions

Authored by mhorne on Dec 10 2020, 3:08 PM.

Details

Reviewers

jhb
kp

Commits

rS368527: riscv: handle debug.debugger_on_trap for fatal page faults

Summary

Allows recovery or diagnosis of a fatal page fault before panicking the
system.

Test Plan

Setting debug.debugger_on_trap=1 and invoking an artificial NULL-dereference enters ddb.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Dec 10 2020, 3:08 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 10 2020, 3:08 PM

mhorne requested review of this revision.Dec 10 2020, 3:08 PM

Harbormaster completed remote builds in B35296: Diff 80517.Dec 10 2020, 3:08 PM

I believe this matches what other platforms do for this sysctl?

This revision is now accepted and ready to land.Dec 10 2020, 9:07 PM

In D27534#615888, @jhb wrote:

I believe this matches what other platforms do for this sysctl?

Certainly looks the same as arm64.

In D27534#615888, @jhb wrote:

I believe this matches what other platforms do for this sysctl?

Yep. With D27535 they should all behave consistently.

Closed by commit rS368527: riscv: handle debug.debugger_on_trap for fatal page faults (authored by mhorne). · Explain WhyDec 10 2020, 10:20 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS368527: riscv: handle debug.debugger_on_trap for fatal page faults.

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

trap.c

12 lines

Diff 80563

View Options

head/sys/riscv/riscv/trap.c

riscv: handle debug.debugger_on_trap for fatal page faultsClosedPublicActions