Handle return from KDB_WHY_TRAP on arm and mips
ClosedPublic
Actions

Authored by mhorne on Dec 10 2020, 3:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 16, 3:09 PM

	Unknown Object (File)
	Thu, Nov 13, 11:07 AM

	Unknown Object (File)
	Wed, Nov 5, 4:18 AM

	Unknown Object (File)
	Thu, Oct 30, 9:17 PM

	Unknown Object (File)
	Thu, Oct 30, 9:57 AM

	Unknown Object (File)
	Wed, Oct 29, 8:54 AM

	Unknown Object (File)
	Sun, Oct 26, 6:27 PM

	Unknown Object (File)
	Sun, Oct 26, 9:34 AM

View All 99 Files

Subscribers

andrew

imp

Details

Reviewers

jhb
avg

Commits

rG65d1a4cfda73: Handle KDB_WHY_TRAP return on arm and mips

Summary

Upon exit from the debugger, checking the return code of kdb_trap()
allows one to retry the fatal page fault. This matches what is done on
all other architectures.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Dec 10 2020, 3:09 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptDec 10 2020, 3:09 PM

mhorne requested review of this revision.Dec 10 2020, 3:09 PM

Harbormaster completed remote builds in B35297: Diff 80518.Dec 10 2020, 3:09 PM

It's been a while since I touched that kind of code, but I think that this change is good.

jhb accepted this revision.Dec 10 2020, 9:08 PM

This revision is now accepted and ready to land.Dec 10 2020, 9:08 PM

mhorne mentioned this in D27534: riscv: handle debug.debugger_on_trap for fatal page faults.Dec 10 2020, 9:12 PM

Closed by commit rG65d1a4cfda73: Handle KDB_WHY_TRAP return on arm and mips (authored by mhorne). · Explain WhyJan 2 2021, 11:07 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG65d1a4cfda73: Handle KDB_WHY_TRAP return on arm and mips.

Revision Contents
Changeset List

Path

Size

sys/

arm/

trap-v6.c

7 lines

mips/

trap.c

7 lines

Diff 81560

View Options

sys/arm/arm/trap-v6.c