Page MenuHomeFreeBSD
Differential D27384

ping: add a ping6 hard link for backwards compatibility
ClosedPublic
Actions

Authored by asomers on Nov 26 2020, 4:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:32 PM
Unknown Object (File)
Fri, Apr 5, 2:17 AM
Unknown Object (File)
Feb 23 2024, 10:21 AM
Unknown Object (File)
Feb 23 2024, 10:21 AM
Unknown Object (File)
Feb 23 2024, 10:07 AM
Unknown Object (File)
Jan 6 2024, 10:24 AM
Unknown Object (File)
Dec 25 2023, 9:05 AM
Unknown Object (File)
Dec 20 2023, 6:30 AM
View All 32 Files
Subscribers
imp

Details

Reviewers
manu
bz
Group Reviewers
manpages
Commits
rS368078: ping: add a ping6 hard link for backwards compatibility
Summary

ping: add a ping6 hard link for backwards compatibility

When invoked as "ping6", ping will now attempt to use ICMPv6 for hostnames
that resolve both IPv4 and IPv6 addresses.

Test Plan

Test case added

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35053
Build 32029: arc lint + arc unit

Event Timeline

asomers created this revision.Nov 26 2020, 4:07 PM
Herald added a reviewer: manpages. · View Herald TranscriptNov 26 2020, 4:07 PM
Herald added a subscriber: imp. · View Herald Transcript
asomers requested review of this revision.Nov 26 2020, 4:07 PM
Harbormaster completed remote builds in B35053: Diff 80023.Nov 26 2020, 4:07 PM
manu added a comment.Nov 26 2020, 4:14 PM

LGTM
Thanks

bz accepted this revision.Nov 26 2020, 4:50 PM

Ignoring the test case (but thanks for adding it) this looks good to me.
Thank you for bringing it back so quickly.

You may or may not merge the two #ifdef INET6 blocks; either way, go ahead please and commit it.

sbin/ping/main.c
76

I wonder if you can merge the two INET6 blocks as

if (strcmp(getprogname(), "ping6") == 0)
   ipv6 = true;
else
   ipv6 = false;
#endif
   ipv4 = false;
This revision is now accepted and ready to land.Nov 26 2020, 4:50 PM
asomers closed this revision.Nov 28 2020, 11:25 PM

Fixed by r368078

asomers added a commit: rS368078: ping: add a ping6 hard link for backwards compatibility.May 30 2021, 6:55 PM

Revision Contents
Changeset List

PathSize
1 line
sbin/
ping/
1 line
5 lines
5 lines
tests/
14 lines
tools/
build/
mk/
1 line

Diff 80023

View Options

ObsoleteFiles.inc

Loading...
View Options

sbin/ping/Makefile

Loading...
View Options

sbin/ping/main.c

Loading...
View Options

sbin/ping/ping.8

Loading...
View Options

sbin/ping/tests/ping_test.sh

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...