Page MenuHomeFreeBSD
Differential D27262

Break down the sglist if VIRTIO_BLK_F_SIZE_MAX is on
Needs ReviewPublic
Actions

Authored by khng on Nov 18 2020, 3:14 AM.
Tags
None
Referenced Files
F158819555: D27262.id79694.diff
Sat, Jun 6, 9:11 AM
Unknown Object (File)
Fri, Jun 5, 5:53 PM
Unknown Object (File)
Fri, Jun 5, 2:32 PM
Unknown Object (File)
Thu, Jun 4, 8:12 PM
Unknown Object (File)
Mon, Jun 1, 3:20 PM
Unknown Object (File)
Sun, May 31, 7:28 AM
Unknown Object (File)
Sat, May 30, 10:25 PM
Unknown Object (File)
Thu, May 28, 11:47 AM
View All Files
Subscribers
delphij
emaste
lwhsu
number201724_me.com
yklaxds_gmail.com

Details

Reviewers
grehan
bryanv
Summary

This change introduce a mechanism to break down the sglist used in
virtio_blk. If VIRTIO_BLK_F_SIZE_MAX is advertised by the host, the
maximum size of each segments in the scatter/gather should be
limited to the size advertised by the host.

Reported by: Yuan Rui <number201724@me.com>
MFC after: 2 weeks

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34883
Build 31904: arc lint + arc unit

Event Timeline

khng requested review of this revision.Nov 18 2020, 3:14 AM
khng created this revision.
Harbormaster completed remote builds in B34870: Diff 79690.Nov 18 2020, 3:14 AM
khng updated this revision to Diff 79691.Nov 18 2020, 3:18 AM
  • Change wordings of comment a bit
Harbormaster completed remote builds in B34871: Diff 79691.Nov 18 2020, 3:18 AM
khng updated this revision to Diff 79694.Nov 18 2020, 4:40 AM
  • Fix some weird lines in vtblk_sg_split_append
Harbormaster completed remote builds in B34873: Diff 79694.Nov 18 2020, 4:40 AM
khng planned changes to this revision.Nov 18 2020, 6:16 AM
khng updated this revision to Diff 79695.Nov 18 2020, 7:37 AM
  • Aggregation of all versions
Harbormaster completed remote builds in B34874: Diff 79695.Nov 18 2020, 7:38 AM
khng added a reviewer: grehan.Nov 18 2020, 8:06 AM
khng updated this revision to Diff 79704.Nov 18 2020, 2:44 PM
  • Remove the unnecessary PAGE_SIZE vs size_max checking
Harbormaster completed remote builds in B34882: Diff 79704.Nov 18 2020, 2:44 PM
khng updated this revision to Diff 79705.Nov 18 2020, 2:49 PM
  • Rename vtblk_max_size to vtblk_size_max to match the spec more
  • Make vtblk_size_max size_t to match sglist(9) more
  • Remove an unnecessary short path for vtblk_sg_split
Harbormaster completed remote builds in B34883: Diff 79705.Nov 18 2020, 2:49 PM
lwhsu added a subscriber: lwhsu.Nov 18 2020, 3:04 PM
grehan added a reviewer: bryanv.Nov 25 2020, 10:17 AM
emaste added a subscriber: emaste.Apr 26 2021, 2:33 PM
number201724_me.com added a subscriber: number201724_me.com.Jun 17 2021, 7:17 AM
delphij added a subscriber: delphij.Jun 17 2021, 7:23 AM

Could you please rebase this to latest main?

sys/dev/virtio/block/virtio_blk.c
322

(Please rebase with the MAXPHYS -> maxphys conversion)

327
727

Based on the context, it appears to me that d_maxsize should be determined by the smaller of maxphys and blkcfg.size_max (we could potentially break atomic semantics if we have to split an I/O request into smaller chunks without upper layers knowing) after this change, so maybe it's time to make the adjustment here?

730

We should probably assert that d_maxsize is always greater than PAGE_SIZE here, and fail attachment when this can't be satisfied. See the proposed "fewer than minimum number of segments" change above.

989–991
yklaxds_gmail.com added a subscriber: yklaxds_gmail.com.Dec 7 2021, 11:42 AM

Now support aliyun update to FreeBSD 13.0 ? But I see it still needs review.

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
block/
122 lines

Diff 79705

View Options

sys/dev/virtio/block/virtio_blk.c

Loading...