Page MenuHomeFreeBSD
Differential D27257

[POWERPC] set default kernel config for powerpc64le and powerpcspe variants
ClosedPublic
Actions

Authored by alfredo on Nov 17 2020, 5:24 PM.
Tags
Referenced Files
F157786318: D27257.id79669.diff
Mon, May 25, 4:27 AM
F157785954: D27257.id79669.diff
Mon, May 25, 4:21 AM
Unknown Object (File)
Tue, May 19, 8:22 AM
Unknown Object (File)
Tue, May 19, 8:17 AM
Unknown Object (File)
Mon, May 18, 5:00 PM
Unknown Object (File)
Mon, May 18, 5:00 PM
Unknown Object (File)
Sun, May 17, 6:36 PM
Unknown Object (File)
Sun, May 17, 3:22 PM
View All Files
Subscribers
emaste
imp
luporl

Details

Reviewers
bdragon
jhibbits
emaste
Commits
rS367907: [POWERPC64LE,POWEPCSPE] set default kernel config for powerpc64le and…
Summary

make buildkernel TARGET=powerpc TARGET_ARCH=powerpc64le currently selects the file GENERIC64 as config file. This makes it select GENERIC64LE instead.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34860
Build 31884: arc lint + arc unit

Event Timeline

alfredo created this revision.Nov 17 2020, 5:24 PM
Herald added subscribers: luporl, emaste. · View Herald TranscriptNov 17 2020, 5:24 PM
alfredo requested review of this revision.Nov 17 2020, 5:24 PM
Harbormaster completed remote builds in B34860: Diff 79669.Nov 17 2020, 5:25 PM
alfredo added inline comments.Nov 17 2020, 5:25 PM
Makefile.inc1
1596

Should we also select MPC85XXSPE when TARGET_ARCH==powerpcspe ?

emaste added a comment.Nov 17 2020, 5:39 PM

LGTM

bdragon accepted this revision.Nov 17 2020, 5:46 PM

Go for it. And yeah, go ahead and add the default powerpcspe kernel too.

This revision is now accepted and ready to land.Nov 17 2020, 5:46 PM
alfredo updated this revision to Diff 79672.Nov 17 2020, 6:11 PM
alfredo retitled this revision from [POWERPC64LE] set default kernel config for LE variant to [POWERPC] set default kernel config for powerpc64le and powerpcspe variants.
alfredo added a reviewer: emaste.

added powerpcspe default config

This revision now requires review to proceed.Nov 17 2020, 6:11 PM
Harbormaster completed remote builds in B34862: Diff 79672.Nov 17 2020, 6:12 PM
alfredo added a comment.Nov 20 2020, 2:44 PM

@emaste do you also agree with latest change? (powerpcspe default config)

emaste added a comment.Nov 20 2020, 3:31 PM

It's fine with me

bdragon accepted this revision.Nov 20 2020, 4:48 PM

Fine by me.

This revision is now accepted and ready to land.Nov 20 2020, 4:49 PM
Closed by commit rS367907: [POWERPC64LE,POWEPCSPE] set default kernel config for powerpc64le and… (authored by alfredo). · Explain WhyNov 20 2020, 7:09 PM
This revision was automatically updated to reflect the committed changes.
alfredo added a commit: rS367907: [POWERPC64LE,POWEPCSPE] set default kernel config for powerpc64le and….
Herald added a subscriber: imp. · View Herald TranscriptNov 20 2020, 7:09 PM

Revision Contents
Changeset List

PathSize
2 lines

Diff 79669

View Options

Makefile.inc1

Loading...