Page MenuHomeFreeBSD
Differential D27247

Fall back to use the GICR address from the distributor struct
ClosedPublic
Actions

Authored by andrew on Nov 17 2020, 11:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 18, 10:52 PM
Unknown Object (File)
Fri, Jun 12, 6:09 PM
Unknown Object (File)
Mon, Jun 8, 10:44 PM
Unknown Object (File)
Sun, Jun 7, 4:36 AM
Unknown Object (File)
Mon, May 25, 4:28 PM
Unknown Object (File)
Mon, May 25, 4:23 PM
Unknown Object (File)
Sun, May 24, 4:41 PM
Unknown Object (File)
Sun, May 24, 4:32 PM
View All Files
Subscribers
afedorov
emaste
imp

Details

Reviewers
f0andrey_gmail.com
manu
Group Reviewers
arm64
Commits
rS367841: Fall back to use the GICR address from the generic interrupt struct
Summary

When there is no ACPI redistributor sub-table in the MADT we need to
fall back to use the GICR base address from the GIC CPU interface
structure.

Handle this fallback when adding memory to the device and when counting
the number of redistributors.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34847
Build 31874: arc lint + arc unit

Event Timeline

andrew created this revision.Nov 17 2020, 11:12 AM
Herald added a reviewer: manu. · View Herald TranscriptNov 17 2020, 11:12 AM
Herald added a subscriber: emaste. · View Herald Transcript
andrew requested review of this revision.Nov 17 2020, 11:12 AM
Harbormaster completed remote builds in B34847: Diff 79646.Nov 17 2020, 11:12 AM
f0andrey_gmail.com added a comment.Nov 17 2020, 5:44 PM

huawei_panic.png (3×1 px, 1 MB)

f0andrey_gmail.com added a comment.Nov 18 2020, 3:11 PM

debug after https://people.freebsd.org/~andrew/0001-Add-debugging-to-the-GICv3-driver.patch https://dpaste.com/2QRXBMSVF

andrew added inline comments.Nov 18 2020, 3:32 PM
sys/arm64/arm64/gic_v3_acpi.c
142

Should be ACPI_MADT_TYPE_GENERIC_INTERRUPT

264

Should be ACPI_MADT_TYPE_GENERIC_INTERRUPT

f0andrey_gmail.com added a comment.Nov 18 2020, 5:22 PM

progress mountroot not found
https://dpaste.com/6RKD9P7AA

afedorov added a subscriber: afedorov.Nov 18 2020, 8:02 PM
f0andrey_gmail.com added a comment.Nov 18 2020, 11:03 PM

Success boot

huawei_boot.png (906×1 px, 494 KB)

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2020, 9:27 AM
Closed by commit rS367841: Fall back to use the GICR address from the generic interrupt struct (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rS367841: Fall back to use the GICR address from the generic interrupt struct.
Herald added a subscriber: imp. · View Herald TranscriptNov 19 2020, 9:27 AM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
47 lines

Diff 79646

View Options

sys/arm64/arm64/gic_v3_acpi.c

Loading...