Details
Details
- Reviewers
vangyzen kib emaste - Commits
- rGb4e4f070eacd: Note that sys/systm.h is special too
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 34427 Build 31531: arc lint + arc unit
Event Timeline
share/man/man9/style.9 | ||
---|---|---|
161 | "...if needed." I know, it seems obvious to you and me, but... |
share/man/man9/style.9 | ||
---|---|---|
161 | I'll add it out of an abundance of caution.... But I'm curious, when would it not be needed? |
share/man/man9/style.9 | ||
---|---|---|
161 | solo% git grep -vl -e sys/systm.h -- sys/kern/*.c | wc -l ~/work/DEV/src 215 |
share/man/man9/style.9 | ||
---|---|---|
161 | Sorry, I don't have a specific example. I'm surprised this document implies that sys/types.h and sys/param.h might not be needed. I can't imagine an example for that, either. |
share/man/man9/style.9 | ||
---|---|---|
161 | I did the same thing, Kostik, but sys/systm.h is included by several other very common headers. |
share/man/man9/style.9 | ||
---|---|---|
161 | That is fine, I think we can rely on such pollution. And if header comes from other route, you do not need to include it. For instance, we (try to) not include sys/types.h if sys/param.h is used. |