Page MenuHomeFreeBSD

Note that sys/systm.h is special too
ClosedPublic

Authored by imp on Oct 27 2020, 9:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 1:01 AM
Unknown Object (File)
Fri, Dec 6, 12:22 AM
Unknown Object (File)
Fri, Dec 6, 12:22 AM
Unknown Object (File)
Tue, Dec 3, 11:26 AM
Unknown Object (File)
Tue, Dec 3, 11:26 AM
Unknown Object (File)
Tue, Dec 3, 11:26 AM
Unknown Object (File)
Tue, Dec 3, 11:15 AM
Unknown Object (File)
Sun, Dec 1, 9:32 PM
Subscribers

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34425
Build 31529: arc lint + arc unit

Event Timeline

imp requested review of this revision.Oct 27 2020, 9:25 PM
imp created this revision.
vangyzen added a subscriber: vangyzen.
vangyzen added inline comments.
share/man/man9/style.9
161

"...if needed."

I know, it seems obvious to you and me, but...

This revision is now accepted and ready to land.Oct 27 2020, 9:31 PM
share/man/man9/style.9
161

I'll add it out of an abundance of caution....

But I'm curious, when would it not be needed?
Not trying to argue, mind you, but I'm coming up empty and would like to know...

This revision now requires review to proceed.Oct 27 2020, 9:41 PM
kib added inline comments.
share/man/man9/style.9
161
solo% git grep -vl -e sys/systm.h -- sys/kern/*.c | wc -l        ~/work/DEV/src
     215
This revision is now accepted and ready to land.Oct 27 2020, 9:45 PM
vangyzen added inline comments.
share/man/man9/style.9
161

Sorry, I don't have a specific example. I'm surprised this document implies that sys/types.h and sys/param.h might not be needed. I can't imagine an example for that, either.

share/man/man9/style.9
161

I did the same thing, Kostik, but sys/systm.h is included by several other very common headers.

share/man/man9/style.9
161

That is fine, I think we can rely on such pollution. And if header comes from other route, you do not need to include it. For instance, we (try to) not include sys/types.h if sys/param.h is used.