Page MenuHomeFreeBSD

iommu_unmap_msi() added
ClosedPublic

Authored by br on Oct 22 2020, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 2, 5:09 AM
Unknown Object (File)
Fri, Dec 20, 8:03 AM
Unknown Object (File)
Thu, Dec 12, 8:07 PM
Unknown Object (File)
Thu, Dec 12, 7:03 AM
Unknown Object (File)
Nov 23 2024, 7:59 AM
Unknown Object (File)
Nov 21 2024, 7:38 AM
Unknown Object (File)
Oct 1 2024, 5:02 AM
Unknown Object (File)
Sep 30 2024, 2:59 PM
Subscribers

Details

Summary

Add iommu de-initialization method for MSI.

This is needed to free up all the entries in GAS tree before iommu domain teardown and pmap release

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Oct 22 2020, 5:04 PM
sys/arm64/arm64/gicv3_its.c
1469 ↗(On Diff #78605)

This blank line is useless.

sys/dev/iommu/iommu_gas.c
738

I think there should be a check entry != NULL and early return. Or assert that entry != NULL.

o Check if entry is not NULL, otherwise return early
o Remove gicv3_its.c changes from this diff. They are moved to https://reviews.freebsd.org/D26878

This revision is now accepted and ready to land.Oct 23 2020, 10:43 PM
sys/kern/subr_intr.c
1374

BTW, what about providing default implementations for iommu_init/deinit, and then dropping #ifdef IOMMU there ?

Add default implementations of iommu_init/deinit

This revision now requires review to proceed.Oct 24 2020, 11:17 AM
This revision is now accepted and ready to land.Oct 24 2020, 4:59 PM
This revision was automatically updated to reflect the committed changes.