Differential D26906

iommu_unmap_msi() added
ClosedPublic
Actions

Authored by br on Oct 22 2020, 5:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 16, 4:59 PM

	Unknown Object (File)
	Fri, Apr 11, 2:23 PM

	Unknown Object (File)
	Sat, Mar 29, 8:06 PM

	Unknown Object (File)
	Mar 19 2025, 6:00 AM

	Unknown Object (File)
	Mar 16 2025, 12:43 PM

	Unknown Object (File)
	Mar 13 2025, 10:20 AM

	Unknown Object (File)
	Mar 12 2025, 10:11 PM

	Unknown Object (File)
	Mar 6 2025, 8:48 AM

View All 96 Files

Subscribers

Details

Reviewers

andrew
kib
manu

Commits

rS367016: o Add iommu de-initialization method for MSI interface.

Summary

Add iommu de-initialization method for MSI.

This is needed to free up all the entries in GAS tree before iommu domain teardown and pmap release

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br created this revision.Oct 22 2020, 5:04 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 22 2020, 5:04 PM

Herald added a subscriber: emaste. · View Herald Transcript

br requested review of this revision.Oct 22 2020, 5:04 PM

kib added inline comments.Oct 23 2020, 5:06 PM

sys/arm64/arm64/gicv3_its.c
1469 ↗	(On Diff #78605)	This blank line is useless.
sys/dev/iommu/iommu_gas.c
738	I think there should be a check entry != NULL and early return. Or assert that entry != NULL.

o Check if entry is not NULL, otherwise return early
o Remove gicv3_its.c changes from this diff. They are moved to https://reviews.freebsd.org/D26878

kib accepted this revision.Oct 23 2020, 10:43 PM

This revision is now accepted and ready to land.Oct 23 2020, 10:43 PM

kib added inline comments.Oct 23 2020, 10:43 PM

sys/kern/subr_intr.c
1380	BTW, what about providing default implementations for iommu_init/deinit, and then dropping #ifdef IOMMU there ?

Add default implementations of iommu_init/deinit

This revision now requires review to proceed.Oct 24 2020, 11:17 AM

kib accepted this revision.Oct 24 2020, 4:59 PM

This revision is now accepted and ready to land.Oct 24 2020, 4:59 PM

Closed by commit rS367016: o Add iommu de-initialization method for MSI interface. (authored by br). · Explain WhyOct 24 2020, 8:09 PM

This revision was automatically updated to reflect the committed changes.

br added a commit: rS367016: o Add iommu de-initialization method for MSI interface..

Herald added a subscriber: imp. · View Herald TranscriptOct 24 2020, 8:09 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

iommu/

25 lines

1 line

kern/

5 lines

8 lines

Diff 78665

sys/dev/iommu/iommu_gas.c

Loading...

sys/dev/iommu/iommu_msi.h

Loading...

sys/kern/msi_if.m

Loading...

sys/kern/subr_intr.c

Loading...