Page MenuHomeFreeBSD
Differential D26653

Use unlocked page lookup for inmem() to avoid object lock contention
ClosedPublic
Actions

Authored by mlaier on Oct 3 2020, 6:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 25 2024, 6:17 PM
Unknown Object (File)
Jan 16 2024, 1:45 PM
Unknown Object (File)
Jan 6 2024, 2:14 AM
Unknown Object (File)
Jan 4 2024, 12:56 PM
Unknown Object (File)
Dec 31 2023, 12:20 AM
Unknown Object (File)
Dec 28 2023, 10:37 PM
Unknown Object (File)
Dec 23 2023, 4:40 AM
Unknown Object (File)
Nov 26 2023, 1:38 AM
View All 38 Files
Subscribers
imp

Details

Reviewers
jeff
kib
markj
bdrewery
Commits
rS366594: Use unlocked page lookup for inmem() to avoid object lock contention
Summary

Let's try this again:

  • make a vm_page_lookup_unlocked
  • really bool-ify
  • while here, export inmem alongside incore (we have a local diff for this)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34068
Build 31249: arc lint + arc unit

Event Timeline

mlaier requested review of this revision.Oct 3 2020, 6:57 PM
mlaier created this revision.
Harbormaster completed remote builds in B33969: Diff 77826.Oct 3 2020, 6:57 PM
mlaier mentioned this in D26597: Use unlocked page lookup for inmem() to avoid object lock contention.Oct 3 2020, 6:58 PM
mlaier updated this revision to Diff 77910.Oct 5 2020, 7:13 PM

Moving the tinc calculation back up - needed for valid range

Harbormaster completed remote builds in B34004: Diff 77910.Oct 5 2020, 7:13 PM
markj accepted this revision.Oct 6 2020, 12:47 PM
markj added inline comments.
sys/vm/vm_page.c
1701

I think this deserves a comment to match the others. e.g., the description for vm_page_lookup(), plus, "The page may be no longer be present in the object at the time that this function returns."

This revision is now accepted and ready to land.Oct 6 2020, 12:47 PM
kib accepted this revision.Oct 6 2020, 2:54 PM
mlaier updated this revision to Diff 78027.Oct 8 2020, 10:14 PM

Add comment per markj's request.

This revision now requires review to proceed.Oct 8 2020, 10:14 PM
Harbormaster completed remote builds in B34068: Diff 78027.Oct 8 2020, 10:14 PM
kib accepted this revision.Oct 8 2020, 10:48 PM
This revision is now accepted and ready to land.Oct 8 2020, 10:48 PM
markj accepted this revision.Oct 9 2020, 3:50 PM
Closed by commit rS366594: Use unlocked page lookup for inmem() to avoid object lock contention (authored by bdrewery). · Explain WhyOct 9 2020, 11:50 PM
This revision was automatically updated to reflect the committed changes.
bdrewery added a commit: rS366594: Use unlocked page lookup for inmem() to avoid object lock contention.
Herald added a subscriber: imp. · View Herald TranscriptOct 9 2020, 11:50 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
45 lines
sys/
1 line
vm/
1 line
15 lines

Diff 78027

View Options

sys/kern/vfs_bio.c

Loading...
View Options

sys/sys/buf.h

Loading...
View Options

sys/vm/vm_page.h

Loading...
View Options

sys/vm/vm_page.c

Loading...